Skip to content

Commit c9761c9

Browse files
committed
Fix git hash calculation with Docker build
Fix error when compiling the Pinetime using the Docker image. If done with Docker, the container does not trust the /sources folder, leading to a blank response of the command that grabs the git commit `git rev-parse --short HEAD`. ``` fatal: detected dubious ownership in repository at '/sources' To add an exception for this directory, call: git config --global --add safe.directory /sources PROJECT_GIT_COMMIT_HASH_SUCCESS? 128 BUILD CONFIGURATION ------------------- * Mode : Release * Version : 1.3.0 * Toolchain : /opt/gcc-arm-none-eabi-10.3-2021.10 * GitRef(S) : * NRF52 SDK : /opt/nRF5_SDK_15.3.0_59ac345 * Target device : PINETIME * Build DFU (using adafruit-nrfutil) : Enabled * Build resources : Enabled ``` If the `git config --global --add safe.directory /sources` is added to the Dockerfile, the problem is solved and the hash is added correctly.
1 parent 02a7a3a commit c9761c9

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

docker/Dockerfile

+3
Original file line numberDiff line numberDiff line change
@@ -55,5 +55,8 @@ RUN bash -c "source /opt/build.sh; GetNrfSdk;"
5555
# McuBoot
5656
RUN bash -c "source /opt/build.sh; GetMcuBoot;"
5757

58+
# Configure Git to accept the /sources directory as safe
59+
RUN git config --global --add safe.directory /sources
60+
5861
ENV SOURCES_DIR /sources
5962
CMD ["/opt/build.sh"]

0 commit comments

Comments
 (0)