Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor DatasetMetadata #311

Open
lr4d opened this issue Jul 21, 2020 · 0 comments
Open

refactor DatasetMetadata #311

lr4d opened this issue Jul 21, 2020 · 0 comments
Labels
refactoring usability Interface is unclear or inconvenient

Comments

@lr4d
Copy link
Collaborator

lr4d commented Jul 21, 2020

  • Make it clearer that DatasetMetadata can be instantiated from DatasetFactory (current method: from_dataset). Suggestion: make this the default and deprecate uuid/store combinations
  • DatasetMetadataBase and DatasetMetadata do not support DatasetFactory properly, instead requiring to pass an instantiated store to methods such as load_all_indices. This is inconsistent with usage of store factories in ktk.io
  • Usage of these classes is quite confusing, seems to be relatively older code created for other kartothek metadata versions. Make common usage simpler: e.g. add argument to load indices to __init__
@lr4d lr4d added the usability Interface is unclear or inconvenient label Jul 21, 2020
@lr4d lr4d added this to the v4.0.0 milestone Jul 21, 2020
@lr4d lr4d mentioned this issue Jul 22, 2020
Open
6 tasks
@fjetter fjetter removed this from the v4.0.0 milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring usability Interface is unclear or inconvenient
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fjetter @lr4d