Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOStream exposes unsafe constructor #58021

Open
jakobnissen opened this issue Apr 6, 2025 · 1 comment · May be fixed by #58023
Open

IOStream exposes unsafe constructor #58021

jakobnissen opened this issue Apr 6, 2025 · 1 comment · May be fixed by #58023
Labels
io Involving the I/O subsystem: libuv, read, write, etc.

Comments

@jakobnissen
Copy link
Member 

julia> f = IOStream("abc", [0x01, 0x02]);

julia> read(f)

[161161] signal 11 (1): Segmentation fault

We should probably hide these constructors behind a non-exported name.
@jakobnissen jakobnissen added the io Involving the I/O subsystem: libuv, read, write, etc. label Apr 6, 2025
@jakobnissen jakobnissen linked a pull request Apr 6, 2025 that will close this issue
Draft
@nsajko
Copy link
Contributor

nsajko commented Apr 6, 2025

👍

A JuliaHub code search suggests the constructors taking more than one argument are not used by any packages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide unsafe constructors of IOStream jakobnissen/julia
2 participants
@nsajko @jakobnissen