Skip to content

Commit 4c7c8c1

Browse files
committed
Rename to clarify that interface itself is not an exception
1 parent 47087a1 commit 4c7c8c1

File tree

5 files changed

+10
-9
lines changed

5 files changed

+10
-9
lines changed

core/api/core.api

+3-3
Original file line numberDiff line numberDiff line change
@@ -5465,7 +5465,7 @@ public final class org/jetbrains/kotlinx/dataframe/exceptions/CellConversionExce
54655465
public final fun getRow ()Ljava/lang/Integer;
54665466
}
54675467

5468-
public final class org/jetbrains/kotlinx/dataframe/exceptions/ColumnNotFoundException : java/lang/RuntimeException, org/jetbrains/kotlinx/dataframe/exceptions/DataFrameException {
5468+
public final class org/jetbrains/kotlinx/dataframe/exceptions/ColumnNotFoundException : java/lang/RuntimeException, org/jetbrains/kotlinx/dataframe/exceptions/DataFrameError {
54695469
public fun <init> (Ljava/lang/String;Ljava/lang/String;)V
54705470
public final fun getColumnName ()Ljava/lang/String;
54715471
public fun getMessage ()Ljava/lang/String;
@@ -5476,11 +5476,11 @@ public final class org/jetbrains/kotlinx/dataframe/exceptions/ColumnTypeMismatch
54765476
public final fun getColumn ()Lorg/jetbrains/kotlinx/dataframe/DataColumn;
54775477
}
54785478

5479-
public abstract interface class org/jetbrains/kotlinx/dataframe/exceptions/DataFrameException {
5479+
public abstract interface class org/jetbrains/kotlinx/dataframe/exceptions/DataFrameError {
54805480
public abstract fun getMessage ()Ljava/lang/String;
54815481
}
54825482

5483-
public final class org/jetbrains/kotlinx/dataframe/exceptions/DuplicateColumnNamesException : java/lang/IllegalArgumentException, org/jetbrains/kotlinx/dataframe/exceptions/DataFrameException {
5483+
public final class org/jetbrains/kotlinx/dataframe/exceptions/DuplicateColumnNamesException : java/lang/IllegalArgumentException, org/jetbrains/kotlinx/dataframe/exceptions/DataFrameError {
54845484
public fun <init> (Ljava/util/List;)V
54855485
public final fun getAllColumnNames ()Ljava/util/List;
54865486
public final fun getDuplicatedNames ()Ljava/util/List;

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/exceptions/ColumnNotFoundException.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ package org.jetbrains.kotlinx.dataframe.exceptions
22

33
public class ColumnNotFoundException(public val columnName: String, public override val message: String) :
44
RuntimeException(),
5-
DataFrameException
5+
DataFrameError
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
package org.jetbrains.kotlinx.dataframe.exceptions
22

33
/**
4-
* If DataFrame function used by compiler plugin as implementation detail throws this exception, [message] will be reported as warning
4+
* If DataFrame function used by compiler plugin as implementation detail throws exception
5+
* that implements this interface, [message] will be reported as warning
56
*/
6-
public interface DataFrameException {
7+
public interface DataFrameError {
78
public val message: String
89
}

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/exceptions/DuplicateColumnNamesException.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package org.jetbrains.kotlinx.dataframe.exceptions
22

33
public class DuplicateColumnNamesException(public val allColumnNames: List<String>) :
44
IllegalArgumentException(),
5-
DataFrameException {
5+
DataFrameError {
66

77
public val duplicatedNames: List<String> = allColumnNames
88
.groupBy { it }

core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/api/constructors.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package org.jetbrains.kotlinx.dataframe.impl.api
22

3-
import org.jetbrains.kotlinx.dataframe.exceptions.DataFrameException
3+
import org.jetbrains.kotlinx.dataframe.exceptions.DataFrameError
44

55
/**
66
* Public API to be re-used in compiler plugin implementation
@@ -25,6 +25,6 @@ public fun <T> Pair<List<String>, List<T>>.withValuesImpl(): List<Pair<String, L
2525

2626
internal class WrongNumberOfValuesException(size: Int, ncol: Int) :
2727
IllegalArgumentException(),
28-
DataFrameException {
28+
DataFrameError {
2929
override val message = "Number of values $size is not divisible by number of columns $ncol"
3030
}

0 commit comments

Comments
 (0)