You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.
The tool only handles two specific external providers: a default (free) one, and a custom (paid) one.
The implementation could be improved by generalizing the support for external providers. Notably, a more robust way of transforming the raw responses into raw transaction and transaction models could be suggested.
Here are some possible checks:
Ensure that the API key is valid (i.e. perform one request and check that there is no authorization issue before running the full scan)
Validate the contents of the response: is it the expected structure? Are the types valid?
Refactor the code to have some kind of dispatcher to select the relevant provider.
The tool only handles two specific external providers: a default (free) one, and a custom (paid) one.
The implementation could be improved by generalizing the support for external providers. Notably, a more robust way of transforming the raw responses into raw transaction and transaction models could be suggested.
Here are some possible checks:
Refactor the code to have some kind of dispatcher to select the relevant provider.
Note that the requests underlying implementation should be improved beforehand.
In this context, see also: #7 (review)
The text was updated successfully, but these errors were encountered: