Skip to content

Commit 125f3c4

Browse files
grandinjNoel Grandin
authored and
Noel Grandin
committed
drawinglayer: create instances with uno constructors
See tdf#74608 for motivation Change-Id: I38de5ec7b9e376ef8868bebbe7f30240de81c241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98219 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
1 parent 33509fd commit 125f3c4

File tree

6 files changed

+16
-138
lines changed

6 files changed

+16
-138
lines changed

drawinglayer/Library_drawinglayer.mk

-1
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ $(eval $(call gb_Library_add_exception_objects,drawinglayer,\
187187
drawinglayer/source/tools/emfpcustomlinecap \
188188
drawinglayer/source/tools/wmfemfhelper \
189189
drawinglayer/source/tools/primitive2dxmldump \
190-
drawinglayer/source/drawinglayeruno/drawinglayeruno \
191190
drawinglayer/source/drawinglayeruno/xprimitive2drenderer \
192191
drawinglayer/source/texture/texture \
193192
drawinglayer/source/dumper/XShapeDumper \

drawinglayer/drawinglayer.component

+3-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,9 @@
1818
-->
1919

2020
<component loader="com.sun.star.loader.SharedLibrary" environment="@CPPU_ENV@"
21-
prefix="drawinglayer" xmlns="http://openoffice.org/2010/uno-components">
22-
<implementation name="drawinglayer::unorenderer::XPrimitive2DRenderer">
21+
xmlns="http://openoffice.org/2010/uno-components">
22+
<implementation name="drawinglayer::unorenderer::XPrimitive2DRenderer"
23+
constructor="drawinglayer_XPrimitive2DRenderer">
2324
<service name="com.sun.star.graphic.Primitive2DTools"/>
2425
</implementation>
2526
</component>

drawinglayer/source/drawinglayeruno/drawinglayeruno.cxx

-55
This file was deleted.

drawinglayer/source/drawinglayeruno/xprimitive2drenderer.cxx

+11-30
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
#include <sal/config.h>
2121

2222
#include <com/sun/star/graphic/XPrimitive2DRenderer.hpp>
23-
#include <com/sun/star/lang/XMultiServiceFactory.hpp>
2423
#include <com/sun/star/lang/XServiceInfo.hpp>
24+
#include <com/sun/star/uno/XComponentContext.hpp>
2525
#include <cppuhelper/implbase2.hxx>
2626
#include <cppuhelper/supportsservice.hxx>
2727
#include <comphelper/sequence.hxx>
@@ -35,8 +35,6 @@
3535

3636
#include <converters.hxx>
3737

38-
#include "xprimitive2drenderer.hxx"
39-
4038
using namespace ::com::sun::star;
4139

4240

@@ -70,32 +68,7 @@ namespace drawinglayer::unorenderer
7068
};
7169

7270
}
73-
} // end of namespace drawinglayer::unorenderer
74-
75-
76-
// uno functions
77-
78-
namespace drawinglayer::unorenderer
79-
{
80-
uno::Sequence< OUString > XPrimitive2DRenderer_getSupportedServiceNames()
81-
{
82-
return { "com.sun.star.graphic.Primitive2DTools" };
83-
}
84-
85-
OUString XPrimitive2DRenderer_getImplementationName()
86-
{
87-
return "drawinglayer::unorenderer::XPrimitive2DRenderer";
88-
}
89-
90-
uno::Reference< uno::XInterface > XPrimitive2DRenderer_createInstance(const uno::Reference< lang::XMultiServiceFactory >&)
91-
{
92-
return static_cast< ::cppu::OWeakObject* >(new XPrimitive2DRenderer);
93-
}
94-
} // end of namespace drawinglayer::unorenderer
95-
9671

97-
namespace drawinglayer::unorenderer
98-
{
9972
XPrimitive2DRenderer::XPrimitive2DRenderer()
10073
{
10174
}
@@ -175,7 +148,7 @@ namespace drawinglayer::unorenderer
175148

176149
OUString SAL_CALL XPrimitive2DRenderer::getImplementationName()
177150
{
178-
return XPrimitive2DRenderer_getImplementationName();
151+
return "drawinglayer::unorenderer::XPrimitive2DRenderer";
179152
}
180153

181154
sal_Bool SAL_CALL XPrimitive2DRenderer::supportsService(const OUString& rServiceName)
@@ -185,9 +158,17 @@ namespace drawinglayer::unorenderer
185158

186159
uno::Sequence< OUString > SAL_CALL XPrimitive2DRenderer::getSupportedServiceNames()
187160
{
188-
return XPrimitive2DRenderer_getSupportedServiceNames();
161+
return { "com.sun.star.graphic.Primitive2DTools" };
189162
}
190163

191164
} // end of namespace
192165

166+
167+
extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface*
168+
drawinglayer_XPrimitive2DRenderer(
169+
css::uno::XComponentContext* , css::uno::Sequence<css::uno::Any> const& )
170+
{
171+
return cppu::acquire(new drawinglayer::unorenderer::XPrimitive2DRenderer());
172+
}
173+
193174
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */

drawinglayer/source/drawinglayeruno/xprimitive2drenderer.hxx

-49
This file was deleted.

solenv/bin/native-code.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
core_factory_list = [
2323
("libembobj.a", "embobj_component_getFactory"),
2424
("libevtattlo.a", "evtatt_component_getFactory"),
25-
("libdrawinglayerlo.a", "drawinglayer_component_getFactory"),
2625
("libfilterconfiglo.a", "filterconfig1_component_getFactory"),
2726
("libfsstoragelo.a", "fsstorage_component_getFactory"),
2827
("libhyphenlo.a", "hyphen_component_getFactory"),
@@ -148,6 +147,8 @@
148147
"com_sun_star_cui_ColorPicker_get_implementation",
149148
# dbaccess/util/dba.component
150149
"com_sun_star_comp_dba_ORowSet_get_implementation",
150+
# drawinglayer/drawinglayer.component
151+
"drawinglayer_XPrimitive2DRenderer",
151152
# emfio/emfio.component
152153
"emfio_emfreader_XEmfParser_get_implementation",
153154
# extensions/source/logging/log.component

0 commit comments

Comments
 (0)