[nrf noup] Do not clear Last Network ID and Connection Error after scan

LuDuda · markaj-nordic · commit abb645f5f4b4 · 2024-03-08T11:18:35.000+01:00
This commit fixes the issue where ScanComplete event cleared the
attribute values for connection status.

This commit should be reverted and replaced by Matter 1.3 revision where
the network commissioning cluster has been rewritten.

Signed-off-by: Łukasz Duda &lt;lukasz.duda@nordicsemi.no&gt;
diff --git a/src/app/clusters/network-commissioning/network-commissioning.cpp b/src/app/clusters/network-commissioning/network-commissioning.cpp
@@ -519,8 +519,6 @@ void Instance::OnFinished(Status status, CharSpan debugText, ThreadScanResponseI
     }
 
     mLastNetworkingStatusValue.SetNonNull(status);
-    mLastConnectErrorValue.SetNull();
-    mLastNetworkIDLen = 0;
 
     TLV::TLVWriter * writer;
     TLV::TLVType listContainerType;
@@ -633,8 +631,6 @@ void Instance::OnFinished(Status status, CharSpan debugText, WiFiScanResponseIte
     }
 
     mLastNetworkingStatusValue.SetNonNull(status);
-    mLastConnectErrorValue.SetNull();
-    mLastNetworkIDLen = 0;
 
     TLV::TLVWriter * writer;
     TLV::TLVType listContainerType;

Original file line number	Diff line number	Diff line change
`@@ -519,8 +519,6 @@ void Instance::OnFinished(Status status, CharSpan debugText, ThreadScanResponseI`
`519`	`519`	`}`
`520`	`520`
`521`	`521`	`mLastNetworkingStatusValue.SetNonNull(status);`
`522`		`- mLastConnectErrorValue.SetNull();`
`523`		`- mLastNetworkIDLen = 0;`
`524`	`522`
`525`	`523`	`TLV::TLVWriter * writer;`
`526`	`524`	`TLV::TLVType listContainerType;`
`@@ -633,8 +631,6 @@ void Instance::OnFinished(Status status, CharSpan debugText, WiFiScanResponseIte`
`633`	`631`	`}`
`634`	`632`
`635`	`633`	`mLastNetworkingStatusValue.SetNonNull(status);`
`636`		`- mLastConnectErrorValue.SetNull();`
`637`		`- mLastNetworkIDLen = 0;`
`638`	`634`
`639`	`635`	`TLV::TLVWriter * writer;`
`640`	`636`	`TLV::TLVType listContainerType;`