Skip to content

Commit f85e66d

Browse files
[nrf noup] followup to wifi issues fix
This commit implement minors from previous wifi fix signed PR number 404. Signed-off-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no>
1 parent 7653e6c commit f85e66d

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

src/platform/nrfconnect/wifi/NrfWiFiDriver.cpp

+11-3
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,16 @@ void NrfWiFiDriver::OnNetworkStatusChanged(int connStatus)
128128
if (CHIP_NO_ERROR == WiFiManager::Instance().GetWiFiInfo(wifiInfo))
129129
{
130130
mpNetworkStatusChangeCallback->OnNetworkingStatusChange(status,
131-
MakeOptional(ByteSpan(wifiInfo.mSsid, wifiInfo.mSsidLen)),
131+
MakeOptional(ByteSpan(wifiInfo.mSsid, wifiInfo.mSsidLen)),
132+
connStatus ? MakeOptional(connStatus) : NullOptional);
133+
}
134+
else
135+
{
136+
WiFiManager::WiFiNetwork wantedWifiInfo;
137+
WiFiManager::Instance().GetWantedNetwork(wantedWifiInfo);
138+
139+
mpNetworkStatusChangeCallback->OnNetworkingStatusChange(
140+
status, MakeOptional(ByteSpan(wantedWifiInfo.ssid, wantedWifiInfo.ssidLen)),
132141
connStatus ? MakeOptional(connStatus) : NullOptional);
133142
}
134143
}
@@ -258,8 +267,7 @@ void NrfWiFiDriver::LoadFromStorage()
258267
void NrfWiFiDriver::OnScanWiFiNetworkDone(const wifi_status & status)
259268
{
260269
VerifyOrReturn(mScanCallback != nullptr);
261-
mScanCallback->OnFinished(status.status ? Status::kUnknownError : Status::kSuccess,
262-
CharSpan(), &mScanResponseIterator);
270+
mScanCallback->OnFinished(status.status ? Status::kUnknownError : Status::kSuccess, CharSpan(), &mScanResponseIterator);
263271
mScanCallback = nullptr;
264272
}
265273

src/platform/nrfconnect/wifi/WiFiManager.cpp

+3-4
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,7 @@ CHIP_ERROR WiFiManager::Connect(const ByteSpan & ssid, const ByteSpan & credenti
210210
{
211211
ChipLogDetail(DeviceLayer, "Connecting to WiFi network: %*s", ssid.size(), ssid.data());
212212

213-
mHandling.mOnConnectionDone = handling.mOnConnectionDone;
214-
mHandling.mConnectionTimeout = handling.mConnectionTimeout;
213+
mHandling = handling;
215214

216215
mWiFiState = WIFI_STATE_ASSOCIATING;
217216

@@ -420,8 +419,8 @@ void WiFiManager::ConnectHandler(Platform::UniquePtr<uint8_t> data)
420419
{
421420
CHIP_ERROR err = SystemLayer().ScheduleLambda([capturedData = data.get()] {
422421
Platform::UniquePtr<uint8_t> safePtr(capturedData);
423-
uint8_t * rawData = safePtr.get();
424-
const wifi_status * status = reinterpret_cast<const wifi_status *>(rawData);
422+
uint8_t * rawData = safePtr.get();
423+
const wifi_status * status = reinterpret_cast<const wifi_status *>(rawData);
425424

426425
if (status->status)
427426
{

src/platform/nrfconnect/wifi/WiFiManager.h

+1
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ class WiFiManager
174174
CHIP_ERROR ClearStationProvisioningData();
175175
CHIP_ERROR Disconnect();
176176
CHIP_ERROR GetWiFiInfo(WiFiInfo & info) const;
177+
const WiFiNetwork & GetWantedNetwork(WiFiNetwork & info) const { return mWantedNetwork; }
177178
CHIP_ERROR GetNetworkStatistics(NetworkStatistics & stats) const;
178179
void AbortConnectionRecovery();
179180
CHIP_ERROR SetLowPowerMode(bool onoff);

0 commit comments

Comments
 (0)