Skip to content

Commit 7a70e80

Browse files
iulian03Iulian Masar
and
Iulian Masar
authored
[bugfix] added missing timeout config for doRequestList() (#356)
* added missing timeout config for doRequestList() * re-enabled test --------- Co-authored-by: Iulian Masar <iulian.masar@codegile.com>
1 parent 744202e commit 7a70e80

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/main/java/com/mangopay/core/RestTool.java

+4
Original file line numberDiff line numberDiff line change
@@ -589,6 +589,10 @@ private <T extends Dto> List<T> doRequestList(Class<T[]> classOfT, Class<T> clas
589589
if (connection instanceof HttpsURLConnection) {
590590
configureSslContext((HttpsURLConnection) connection);
591591
}
592+
// Get connection timeout from config
593+
connection.setConnectTimeout(this.root.getConfig().getConnectTimeout());
594+
// Get read timeout from config
595+
connection.setReadTimeout(this.root.getConfig().getReadTimeout());
592596

593597
// set request method
594598
connection.setRequestMethod(this.requestType);

src/test/java/com/mangopay/core/VirtualAccountApiImplTest.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import com.mangopay.entities.VirtualAccount;
44
import com.mangopay.entities.Wallet;
55
import com.mangopay.entities.subentities.VirtualAccountAvailabilities;
6-
import org.junit.Ignore;
76
import org.junit.Test;
87

98
import java.util.List;
@@ -46,15 +45,13 @@ public void getAllVirtualAccounts() throws Exception {
4645
assertEquals(1, virtualAccounts.size());
4746
}
4847

49-
// TODO
50-
@Ignore("API issue. Re-enable after fix.")
5148
@Test
5249
public void getAvailabilities() throws Exception {
5350
VirtualAccountAvailabilities availabilities = this.api.getVirtualAccountApi().getAvailabilities();
5451

5552
assertNotNull(availabilities);
56-
assertTrue(availabilities.getCollection().getClass().isArray());
57-
assertTrue(availabilities.getUserOwned().getClass().isArray());
53+
assertFalse(availabilities.getCollection().isEmpty());
54+
assertFalse(availabilities.getUserOwned().isEmpty());
5855
}
5956

6057
@Test

0 commit comments

Comments
 (0)