Skip to content

Commit 9027116

Browse files
iulian03Iulian Masar
and
Iulian Masar
authored
refactored sca enrollment (#362)
Co-authored-by: Iulian Masar <iulian.masar@codegile.com>
1 parent debb542 commit 9027116

File tree

5 files changed

+12
-10
lines changed

5 files changed

+12
-10
lines changed

src/main/java/com/mangopay/core/APIs/ApiBase.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ protected MangoPayApi getRoot() {
158158
put("users_categorizelegals_sca", new String[]{"/sca/users/legal/%s/category", RequestType.PUT.toString()});
159159
put("users_block_status", new String[]{"/users/%s/blockStatus", RequestType.GET.toString()});
160160
put("users_regulatory", new String[]{"/users/%s/Regulatory", RequestType.GET.toString()});
161-
put("users_activate_sca", new String[]{"/sca/users/%s/activation", RequestType.POST.toString()});
161+
put("users_enroll_sca", new String[]{"/sca/users/%s/enrollment", RequestType.POST.toString()});
162162

163163
put("users_emoney_year", new String[]{"/users/%s/emoney/%s", RequestType.GET.toString()});
164164
put("users_emoney_month", new String[]{"/users/%s/emoney/%s/%s", RequestType.GET.toString()});

src/main/java/com/mangopay/core/APIs/UserApi.java

+5-3
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import com.mangopay.core.enumerations.CurrencyIso;
88
import com.mangopay.core.enumerations.KycDocumentType;
99
import com.mangopay.entities.*;
10-
import com.mangopay.entities.subentities.ActivateUserResult;
10+
import com.mangopay.entities.subentities.UserEnrollmentResult;
1111

1212
import java.util.List;
1313

@@ -136,13 +136,15 @@ public interface UserApi {
136136
User categorize(User user) throws Exception;
137137

138138
/**
139-
* Obtain a new SCA redirection link to authenticate a user
139+
* If UserCategory is OWNER, this endpoint allows you to enroll a user in SCA.
140+
* Your platform needs to retrieve the returned PendingUserAction.RedirectUrl,
141+
* add an encoded returnUrl query parameter for them to be returned to after the SCA session, and redirect the user.
140142
*
141143
* @param userId User identifier
142144
* @return User for that User
143145
* @throws Exception
144146
*/
145-
ActivateUserResult activate(String userId) throws Exception;
147+
UserEnrollmentResult enroll(String userId) throws Exception;
146148

147149
/**
148150
* Creates bank account for user.

src/main/java/com/mangopay/core/APIs/implementation/UserApiImpl.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
import com.mangopay.core.serializer.BankAccountSerializer;
1616
import com.mangopay.core.serializer.UserSerializer;
1717
import com.mangopay.entities.*;
18-
import com.mangopay.entities.subentities.ActivateUserResult;
18+
import com.mangopay.entities.subentities.UserEnrollmentResult;
1919
import org.apache.commons.codec.binary.Base64;
2020

2121
import java.nio.file.Files;
@@ -154,8 +154,8 @@ else if (user instanceof UserLegalSca || user instanceof UserLegal)
154154
}
155155

156156
@Override
157-
public ActivateUserResult activate(String userId) throws Exception {
158-
return this.createObject(ActivateUserResult.class, null, "users_activate_sca", null, userId);
157+
public UserEnrollmentResult enroll(String userId) throws Exception {
158+
return this.createObject(UserEnrollmentResult.class, null, "users_enroll_sca", null, userId);
159159
}
160160

161161
@Override

src/main/java/com/mangopay/entities/subentities/ActivateUserResult.java src/main/java/com/mangopay/entities/subentities/UserEnrollmentResult.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import com.google.gson.annotations.SerializedName;
44
import com.mangopay.core.Dto;
55

6-
public class ActivateUserResult extends Dto {
6+
public class UserEnrollmentResult extends Dto {
77

88
/**
99
* Information about the action required from the user if action was triggered by the API call (otherwise returned null).

src/test/java/com/mangopay/core/UserApiImplTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -289,9 +289,9 @@ public void categorizeLegalSca() throws Exception {
289289
}
290290

291291
@Test
292-
public void activateNaturalSca() throws Exception {
292+
public void enrollNaturalSca() throws Exception {
293293
UserNaturalSca johnSca = this.getJohnSca();
294-
ActivateUserResult result = this.api.getUserApi().activate(johnSca.getId());
294+
UserEnrollmentResult result = this.api.getUserApi().enroll(johnSca.getId());
295295

296296
assertNotNull(johnSca.getPendingUserAction().getRedirectUrl());
297297
assertNotNull(result.getPendingUserAction().getRedirectUrl());

0 commit comments

Comments
 (0)