Merge pull request #351 from Mangopay/improvement/update-transaction-tests

Improved Trasanction tests

Author: iulian03

src/main/java/com/mangopay/entities/Refund.java

@@ -43,9 +43,6 @@ public class Refund extends Transaction {
     @SerializedName("RefundReason")
     private RefundReason refundReason;
 
-    @SerializedName("Reference")
-    private String reference;
-
     @SerializedName("StatementDescriptor")
     private String statementDescriptor;
 
@@ -89,14 +86,6 @@ public void setRefundReason(com.mangopay.core.RefundReason refundReason) {
         this.refundReason = refundReason;
     }
 
-    public String getReference() {
-        return reference;
-    }
-
-    public void setReference(String reference) {
-        this.reference = reference;
-    }
-
     public String getStatementDescriptor() {
         return statementDescriptor;
     }

src/test/java/com/mangopay/core/BaseTest.java

@@ -1298,7 +1298,6 @@ protected Refund getNewRefundForPayIn(PayIn payIn) throws Exception {
         refund.setFees(new Money());
         refund.getFees().setAmount(payIn.getFees().getAmount());
         refund.getFees().setCurrency(payIn.getFees().getCurrency());
-        refund.setReference("Reference");
 
         return this.api.getPayInApi().createRefund(payIn.getId(), refund);
     }

src/test/java/com/mangopay/core/CardApiImplTest.java

@@ -1,6 +1,7 @@
 package com.mangopay.core;
 
 import com.mangopay.core.APIs.CardApi;
+import com.mangopay.core.enumerations.TransactionStatus;
 import com.mangopay.core.enumerations.TransactionType;
 import com.mangopay.entities.*;
 import com.mangopay.entities.subentities.PayInPaymentDetailsCard;
@@ -38,6 +39,11 @@ public void getTransactions() throws Exception {
 
         assertNotNull("Card transactions came back null", transactions);
         assertFalse("Api returned an empty list of card transactions", transactions.isEmpty());
+
+        for (Transaction t : transactions) {
+            assertNotNull(t.getStatus());
+            assertNotEquals(TransactionStatus.NotSpecified, t.getStatus());
+        }
     }
 
     @Test

src/test/java/com/mangopay/core/DisputeApiImplTest.java

@@ -30,7 +30,7 @@
 /**
  * DisputeApiImpl test methods.
  */
-@Ignore("Comment this line out to allow DisputeApi unit tests run")
+
 public class DisputeApiImplTest extends BaseTest {
 
     private List<Dispute> clientDisputes = null;
@@ -74,6 +74,11 @@ public void getTransactions() throws Exception {
 
         assertNotNull(result);
         assertFalse(result.isEmpty());
+
+        for (Transaction t : result) {
+            assertNotNull(t.getStatus());
+            assertNotEquals(TransactionStatus.NotSpecified, t.getStatus());
+        }
     }
 
     @Test
@@ -114,6 +119,12 @@ public void getDisputesForUser() throws Exception {
 
         assertNotNull(result);
         assertFalse(result.isEmpty());
+
+        assertFalse(transactions.isEmpty());
+        for (Transaction t : transactions) {
+            assertNotNull(t.getStatus());
+            assertNotEquals(TransactionStatus.NotSpecified, t.getStatus());
+        }
     }
 
     @Test
@@ -169,6 +180,7 @@ public void createDisputePage() throws Exception {
     }
 
     @Test
+    @Ignore("Cannot be tested. Needs manual creation of dispute on API side")
     public void contestDispute() throws Exception {
         Dispute notContestedDispute = null;
 
@@ -211,6 +223,7 @@ public void saveTag() throws Exception {
     }
 
     @Test
+    @Ignore("Cannot be tested. Needs manual creation of dispute on API side")
     public void closeDispute() throws Exception {
         Dispute dispute = null;
 
@@ -328,6 +341,7 @@ public void getDocumentsForClient() throws Exception {
     }
 
     @Test
+    @Ignore("Cannot be tested. Needs manual creation of dispute on API side")
     public void submitDisputeDocument() throws Exception {
         Dispute dispute = null;
         DisputeDocument disputeDocument = null;
@@ -507,6 +521,7 @@ public void getFilteredDisputeDocuments() throws Exception {
     }
 
     @Test
+    @Ignore("Cannot be tested. Needs manual creation of dispute on API side")
     public void resubmitDispute() throws Exception {
         Dispute dispute = null;
 

src/test/java/com/mangopay/core/PayInApiImplTest.java

@@ -288,6 +288,12 @@ public void createPreAuthorizedDirect() {
 
             List<Transaction> preAuthTransactions = this.api.getCardPreAuthorizationApi().getTransactions(cardPreAuthorization.getId(), new Pagination(1, 1));
 
+            assertFalse(preAuthTransactions.isEmpty());
+            for (Transaction t : preAuthTransactions) {
+                assertNotNull(t.getStatus());
+                assertNotEquals(TransactionStatus.NotSpecified, t.getStatus());
+            }
+
             assertTrue(!"".equals(createPayIn.getId()));
             assertEquals(wallet.getId(), createPayIn.getCreditedWalletId());
             assertTrue(createPayIn.getPaymentType() == PayInPaymentType.PREAUTHORIZED);

src/test/java/com/mangopay/core/UserApiImplTest.java

@@ -636,6 +636,12 @@ public void getTransactions() throws Exception {
 
         List<Transaction> transactions = this.api.getUserApi().getTransactions(john.getId(), pagination, new FilterTransactions(), null);
 
+        assertFalse(transactions.isEmpty());
+        for (Transaction t : transactions) {
+            assertNotNull(t.getStatus());
+            assertNotEquals(TransactionStatus.NotSpecified, t.getStatus());
+        }
+
         assertTrue(transactions.size() > 0);
         assertTrue(transactions.get(0).getType() != null);
         assertTrue(transactions.get(0).getStatus() != null);
@@ -653,6 +659,12 @@ public void getTransactionsAndSortByCreationDate() throws Exception {
 
         List<Transaction> transactions = this.api.getUserApi().getTransactions(john.getId(), pagination, new FilterTransactions(), sorting);
 
+        assertFalse(transactions.isEmpty());
+        for (Transaction t : transactions) {
+            assertNotNull(t.getStatus());
+            assertNotEquals(TransactionStatus.NotSpecified, t.getStatus());
+        }
+
         assertNotNull(transactions);
         assertTrue(transactions.size() > 1);
         assertTrue(transactions.get(0).getCreationDate() > transactions.get(1).getCreationDate());

src/test/java/com/mangopay/core/WalletApiImplTest.java

@@ -1,6 +1,7 @@
 package com.mangopay.core;
 
 import com.mangopay.core.enumerations.SortDirection;
+import com.mangopay.core.enumerations.TransactionStatus;
 import com.mangopay.core.enumerations.TransactionType;
 import com.mangopay.entities.PayIn;
 import com.mangopay.entities.Transaction;
@@ -67,6 +68,12 @@ public void getWalletTransactions() throws Exception {
         assertTrue(transactions.get(0) instanceof Transaction);
         assertEquals(transactions.get(0).getAuthorId(), john.getId());
         //this.assertEqualInputProps(transactions.get(0), payIn);
+
+        assertFalse(transactions.isEmpty());
+        for (Transaction t : transactions) {
+            assertNotNull(t.getStatus());
+            assertNotEquals(TransactionStatus.NotSpecified, t.getStatus());
+        }
     }
 
     @Test
@@ -89,5 +96,11 @@ public void getWalletTransactionsAndSortByCreationDate() throws Exception {
         assertNotNull(transactions);
         assertTrue(transactions.size() > 1);
         assertTrue(transactions.get(0).getCreationDate() > transactions.get(1).getCreationDate());
+
+        assertFalse(transactions.isEmpty());
+        for (Transaction t : transactions) {
+            assertNotNull(t.getStatus());
+            assertNotEquals(TransactionStatus.NotSpecified, t.getStatus());
+        }
     }
 }