Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Csla core projects depends on Csla.Generator.AutoSerialization.Attributes.CSharp #4604

Open
ossendorf-at-hoelscher opened this issue Mar 15, 2025 · 1 comment · May be fixed by #4626
Open

Csla core projects depends on Csla.Generator.AutoSerialization.Attributes.CSharp #4604

ossendorf-at-hoelscher opened this issue Mar 15, 2025 · 1 comment · May be fixed by #4626
Assignees
@StefanOssendorf
Labels
area/analyzers CSLA .NET analyzers kind/technical debt

Comments

@ossendorf-at-hoelscher
Copy link

Describe the bug
With a recent PR the dependency Csla.Generator.AutoSerialization.Attributes.CSharp was added to the Csla core library. I think it was with my NRT PR. We have to fix that before we consider a v10 pre-release.

Version and Platform
CSLA version: main
OS: Windows
@ossendorf-at-hoelscher
Copy link
Author

Solution is adding PrivateAssets="all" to the include.
<ProjectReference Include="..\Csla.Generators\cs\AutoSerialization\Csla.Generator.AutoSerialization.Attributes.CSharp\Csla.Generator.AutoSerialization.Attributes.CSharp.csproj" ReferenceOutputAssembly="true" OutputItemType="Analyzer" PrivateAssets="all" />

StefanOssendorf added a commit that referenced this issue Apr 4, 2025
@StefanOssendorf
Make generator dependency internal
d4d2543 
Fixes #4604
@StefanOssendorf StefanOssendorf linked a pull request Apr 4, 2025 that will close this issue
Open
@StefanOssendorf StefanOssendorf self-assigned this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanOssendorf StefanOssendorf

Labels
area/analyzers CSLA .NET analyzers kind/technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make generator dependency internal MarimerLLC/csla
3 participants
@rockfordlhotka @StefanOssendorf @ossendorf-at-hoelscher