Skip to content

Commit 2b25cd1

Browse files
snowmeadsnowmead
authored
add int test challenge cycle (#315)
1 parent cace3f0 commit 2b25cd1

File tree

2 files changed

+334
-1
lines changed

2 files changed

+334
-1
lines changed

‎pallets/providers/src/utils.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -857,7 +857,7 @@ where
857857
// Clear the accrued failed proof submissions for the Storage Provider
858858
<T::ProvidersProofSubmitters as ProofSubmittersInterface>::clear_accrued_failed_proof_submissions(&provider_id);
859859

860-
// Slash the held deposit since there's not enough free balance
860+
// Slash the held deposit
861861
let actual_slashed = T::NativeBalance::transfer_on_hold(
862862
&HoldReason::StorageProviderDeposit.into(),
863863
&account_id,

‎test/suites/integration/bsp/challenge-cycle-2.test.ts

+333
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,333 @@
1+
import assert, { strictEqual } from "node:assert";
2+
import { bspKey, describeBspNet, sleep, type EnrichedBspApi } from "../../../util";
3+
4+
describeBspNet(
5+
"BSPNet: BSP Challenge Cycle and Proof Submission with changed capacity",
6+
{ initialised: true },
7+
({ it, before, createBspApi, createUserApi }) => {
8+
let userApi: EnrichedBspApi;
9+
let bspApi: EnrichedBspApi;
10+
11+
before(async () => {
12+
userApi = await createUserApi();
13+
bspApi = await createBspApi();
14+
});
15+
16+
it("Network launches and can be queried", async () => {
17+
const userNodePeerId = await userApi.rpc.system.localPeerId();
18+
strictEqual(userNodePeerId.toString(), userApi.shConsts.NODE_INFOS.user.expectedPeerId);
19+
20+
const bspNodePeerId = await bspApi.rpc.system.localPeerId();
21+
strictEqual(bspNodePeerId.toString(), userApi.shConsts.NODE_INFOS.bsp.expectedPeerId);
22+
});
23+
24+
it("BSP is challenged and correctly submits proof", async () => {
25+
// Calculate the next challenge tick for the BSP.
26+
// We first get the last tick for which the BSP submitted a proof.
27+
const lastTickResult = await userApi.call.proofsDealerApi.getLastTickProviderSubmittedProof(
28+
userApi.shConsts.DUMMY_BSP_ID
29+
);
30+
assert(lastTickResult.isOk);
31+
const lastTickBspSubmittedProof = lastTickResult.asOk.toNumber();
32+
// Then we get the challenge period for the BSP.
33+
const challengePeriodResult = await userApi.call.proofsDealerApi.getChallengePeriod(
34+
userApi.shConsts.DUMMY_BSP_ID
35+
);
36+
assert(challengePeriodResult.isOk);
37+
const challengePeriod = challengePeriodResult.asOk.toNumber();
38+
// Then we calculate the next challenge tick.
39+
const nextChallengeTick = lastTickBspSubmittedProof + challengePeriod;
40+
41+
// Calculate how many blocks to advance until next challenge tick.
42+
const currentBlockNumber = (await userApi.query.system.number()).toNumber();
43+
const blocksToAdvance = nextChallengeTick - currentBlockNumber;
44+
45+
// Advance blocksToAdvance blocks.
46+
for (let i = 0; i < blocksToAdvance; i++) {
47+
await userApi.sealBlock();
48+
}
49+
50+
// Wait for task to execute and seal one more block.
51+
// In this block, the BSP should have submitted a proof.
52+
await sleep(500);
53+
await userApi.sealBlock();
54+
55+
// Assert for the the event of the proof successfully submitted and verified.
56+
await userApi.assert.eventPresent("proofsDealer", "ProofAccepted");
57+
});
58+
59+
it("BSP's stake increased while next challenge deadline not changed", async () => {
60+
// Get current next deadline tick for BSP
61+
const initialNextDeadlineResult = await userApi.call.proofsDealerApi.getNextDeadlineTick(
62+
userApi.shConsts.DUMMY_BSP_ID
63+
);
64+
assert(initialNextDeadlineResult.isOk);
65+
const initialNextDeadline = initialNextDeadlineResult.asOk.toNumber();
66+
67+
// Skip to minimum change time before trying to change capacity
68+
await userApi.block.skipToMinChangeTime();
69+
70+
// Get current capacity to calculate increase
71+
const currentBspMetadata = await userApi.query.providers.backupStorageProviders(
72+
userApi.shConsts.DUMMY_BSP_ID
73+
);
74+
assert(currentBspMetadata.isSome);
75+
const currentCapacity = currentBspMetadata.unwrap().capacity.toBigInt();
76+
const newCapacity = currentCapacity + BigInt(1024 * 1024); // Increase by 1MB
77+
78+
// Send transaction to increase capacity
79+
await userApi.wait.waitForAvailabilityToSendTx(bspKey.address.toString());
80+
const { extSuccess } = await userApi.sealBlock(
81+
userApi.tx.providers.changeCapacity(newCapacity),
82+
bspKey
83+
);
84+
strictEqual(extSuccess, true, "Change capacity transaction should succeed");
85+
86+
// Assert the capacity change event was emitted
87+
await userApi.assert.eventPresent("providers", "CapacityChanged");
88+
89+
// Verify capacity was actually increased
90+
const updatedBspMetadata = await userApi.query.providers.backupStorageProviders(
91+
userApi.shConsts.DUMMY_BSP_ID
92+
);
93+
assert(updatedBspMetadata.isSome);
94+
strictEqual(
95+
updatedBspMetadata.unwrap().capacity.toBigInt(),
96+
newCapacity,
97+
"BSP capacity should be updated to new value"
98+
);
99+
100+
// Verify next deadline remains unchanged
101+
const currentNextDeadlineResult = await userApi.call.proofsDealerApi.getNextDeadlineTick(
102+
userApi.shConsts.DUMMY_BSP_ID
103+
);
104+
assert(currentNextDeadlineResult.isOk);
105+
const currentNextDeadline = currentNextDeadlineResult.asOk.toNumber();
106+
107+
strictEqual(
108+
currentNextDeadline,
109+
initialNextDeadline,
110+
"Next deadline should not change after increasing capacity"
111+
);
112+
});
113+
114+
it("Next challenge tick correctly calculated with new shorter period", async () => {
115+
// Get current challenge period (which should already reflect the increased capacity)
116+
const challengePeriodResult = await userApi.call.proofsDealerApi.getChallengePeriod(
117+
userApi.shConsts.DUMMY_BSP_ID
118+
);
119+
assert(challengePeriodResult.isOk);
120+
const challengePeriod = challengePeriodResult.asOk.toNumber();
121+
122+
// Get the last tick for which the BSP submitted a proof
123+
const lastTickResult = await userApi.call.proofsDealerApi.getLastTickProviderSubmittedProof(
124+
userApi.shConsts.DUMMY_BSP_ID
125+
);
126+
assert(lastTickResult.isOk);
127+
const lastTickBspSubmittedProof = lastTickResult.asOk.toNumber();
128+
129+
// Calculate next challenge tick
130+
const nextChallengeTick = lastTickBspSubmittedProof + challengePeriod;
131+
132+
// Calculate how many blocks to advance until next challenge tick
133+
const currentBlock = (await userApi.query.system.number()).toNumber();
134+
const blocksToAdvance = nextChallengeTick - currentBlock;
135+
136+
// Advance blocks until next challenge tick
137+
for (let i = 0; i < blocksToAdvance; i++) {
138+
await userApi.sealBlock();
139+
}
140+
141+
// Wait for BSP to submit proof and seal one more block
142+
await sleep(500);
143+
await userApi.sealBlock();
144+
145+
// Verify proof was submitted successfully
146+
await userApi.assert.eventPresent("proofsDealer", "ProofAccepted");
147+
148+
// Now get the new last tick and verify next deadline calculation
149+
const newLastTickResult =
150+
await userApi.call.proofsDealerApi.getLastTickProviderSubmittedProof(
151+
userApi.shConsts.DUMMY_BSP_ID
152+
);
153+
assert(newLastTickResult.isOk);
154+
const newLastTickBspSubmittedProof = newLastTickResult.asOk.toNumber();
155+
156+
// Get the next deadline tick
157+
const nextDeadlineResult = await userApi.call.proofsDealerApi.getNextDeadlineTick(
158+
userApi.shConsts.DUMMY_BSP_ID
159+
);
160+
assert(nextDeadlineResult.isOk);
161+
const nextDeadline = nextDeadlineResult.asOk.toNumber();
162+
163+
// Next deadline should be last proof tick + challenge period + tolerance
164+
const challengeTicksTolerance = Number(userApi.consts.proofsDealer.challengeTicksTolerance);
165+
const expectedNextDeadline =
166+
newLastTickBspSubmittedProof + challengePeriod + challengeTicksTolerance;
167+
168+
strictEqual(
169+
nextDeadline,
170+
expectedNextDeadline,
171+
"Next deadline should be calculated using current challenge period"
172+
);
173+
});
174+
175+
it("Challenge period adjusts correctly when capacity is decreased", async () => {
176+
// Get current capacity
177+
const currentBspMetadata = await userApi.query.providers.backupStorageProviders(
178+
userApi.shConsts.DUMMY_BSP_ID
179+
);
180+
assert(currentBspMetadata.isSome);
181+
const currentCapacity = currentBspMetadata.unwrap().capacity.toBigInt();
182+
183+
// Calculate new lower capacity (decrease by 1MB)
184+
const decreaseAmount = BigInt(1024 * 1024); // 1MB
185+
const newCapacity = currentCapacity - decreaseAmount;
186+
187+
// Skip to minimum change time before trying to change capacity
188+
await userApi.block.skipToMinChangeTime();
189+
190+
// Send transaction to decrease capacity
191+
await userApi.wait.waitForAvailabilityToSendTx(bspKey.address.toString());
192+
const { extSuccess } = await userApi.sealBlock(
193+
userApi.tx.providers.changeCapacity(newCapacity),
194+
bspKey
195+
);
196+
strictEqual(extSuccess, true, "Change capacity transaction should succeed");
197+
198+
// Assert the capacity change event was emitted
199+
await userApi.assert.eventPresent("providers", "CapacityChanged");
200+
201+
// Verify capacity was actually decreased
202+
const updatedBspMetadata = await userApi.query.providers.backupStorageProviders(
203+
userApi.shConsts.DUMMY_BSP_ID
204+
);
205+
assert(updatedBspMetadata.isSome);
206+
strictEqual(
207+
updatedBspMetadata.unwrap().capacity.toBigInt(),
208+
newCapacity,
209+
"BSP capacity should be updated to new lower value"
210+
);
211+
212+
// Get current challenge period (which should reflect the decreased capacity)
213+
const challengePeriodResult = await userApi.call.proofsDealerApi.getChallengePeriod(
214+
userApi.shConsts.DUMMY_BSP_ID
215+
);
216+
assert(challengePeriodResult.isOk);
217+
const challengePeriod = challengePeriodResult.asOk.toNumber();
218+
219+
// Get the last tick for which the BSP submitted a proof
220+
const lastTickResult = await userApi.call.proofsDealerApi.getLastTickProviderSubmittedProof(
221+
userApi.shConsts.DUMMY_BSP_ID
222+
);
223+
assert(lastTickResult.isOk);
224+
const lastTickBspSubmittedProof = lastTickResult.asOk.toNumber();
225+
226+
// Calculate next challenge tick
227+
const nextChallengeTick = lastTickBspSubmittedProof + challengePeriod;
228+
229+
// Calculate how many blocks to advance until next challenge tick
230+
const currentBlock = (await userApi.query.system.number()).toNumber();
231+
const blocksToAdvance = nextChallengeTick - currentBlock;
232+
233+
// Advance blocks until next challenge tick
234+
for (let i = 0; i < blocksToAdvance; i++) {
235+
await userApi.sealBlock();
236+
}
237+
238+
// Wait for BSP to submit proof and seal one more block
239+
await sleep(500);
240+
await userApi.sealBlock();
241+
242+
// Verify proof was submitted successfully
243+
await userApi.assert.eventPresent("proofsDealer", "ProofAccepted");
244+
245+
// Now get the new last tick and verify next deadline calculation
246+
const newLastTickResult =
247+
await userApi.call.proofsDealerApi.getLastTickProviderSubmittedProof(
248+
userApi.shConsts.DUMMY_BSP_ID
249+
);
250+
assert(newLastTickResult.isOk);
251+
const newLastTickBspSubmittedProof = newLastTickResult.asOk.toNumber();
252+
253+
// Get the next deadline tick
254+
const nextDeadlineResult = await userApi.call.proofsDealerApi.getNextDeadlineTick(
255+
userApi.shConsts.DUMMY_BSP_ID
256+
);
257+
assert(nextDeadlineResult.isOk);
258+
const nextDeadline = nextDeadlineResult.asOk.toNumber();
259+
260+
// Next deadline should be last proof tick + challenge period + tolerance
261+
const challengeTicksTolerance = Number(userApi.consts.proofsDealer.challengeTicksTolerance);
262+
const expectedNextDeadline =
263+
newLastTickBspSubmittedProof + challengePeriod + challengeTicksTolerance;
264+
265+
strictEqual(
266+
nextDeadline,
267+
expectedNextDeadline,
268+
"Next deadline should be calculated using current challenge period"
269+
);
270+
});
271+
272+
it("Next challenge tick correctly calculated with new longer period", async () => {
273+
// Get current challenge period (which should already reflect the decreased capacity)
274+
const challengePeriodResult = await userApi.call.proofsDealerApi.getChallengePeriod(
275+
userApi.shConsts.DUMMY_BSP_ID
276+
);
277+
assert(challengePeriodResult.isOk);
278+
const challengePeriod = challengePeriodResult.asOk.toNumber();
279+
280+
// Get the last tick for which the BSP submitted a proof
281+
const lastTickResult = await userApi.call.proofsDealerApi.getLastTickProviderSubmittedProof(
282+
userApi.shConsts.DUMMY_BSP_ID
283+
);
284+
assert(lastTickResult.isOk);
285+
const lastTickBspSubmittedProof = lastTickResult.asOk.toNumber();
286+
287+
// Calculate next challenge tick
288+
const nextChallengeTick = lastTickBspSubmittedProof + challengePeriod;
289+
290+
// Calculate how many blocks to advance until next challenge tick
291+
const currentBlock = (await userApi.query.system.number()).toNumber();
292+
const blocksToAdvance = nextChallengeTick - currentBlock;
293+
294+
// Advance blocks until next challenge tick
295+
for (let i = 0; i < blocksToAdvance; i++) {
296+
await userApi.sealBlock();
297+
}
298+
299+
// Wait for BSP to submit proof and seal one more block
300+
await sleep(500);
301+
await userApi.sealBlock();
302+
303+
// Verify proof was submitted successfully
304+
await userApi.assert.eventPresent("proofsDealer", "ProofAccepted");
305+
306+
// Now get the new last tick and verify next deadline calculation
307+
const newLastTickResult =
308+
await userApi.call.proofsDealerApi.getLastTickProviderSubmittedProof(
309+
userApi.shConsts.DUMMY_BSP_ID
310+
);
311+
assert(newLastTickResult.isOk);
312+
const newLastTickBspSubmittedProof = newLastTickResult.asOk.toNumber();
313+
314+
// Get the next deadline tick
315+
const nextDeadlineResult = await userApi.call.proofsDealerApi.getNextDeadlineTick(
316+
userApi.shConsts.DUMMY_BSP_ID
317+
);
318+
assert(nextDeadlineResult.isOk);
319+
const nextDeadline = nextDeadlineResult.asOk.toNumber();
320+
321+
// Next deadline should be last proof tick + challenge period + tolerance
322+
const challengeTicksTolerance = Number(userApi.consts.proofsDealer.challengeTicksTolerance);
323+
const expectedNextDeadline =
324+
newLastTickBspSubmittedProof + challengePeriod + challengeTicksTolerance;
325+
326+
strictEqual(
327+
nextDeadline,
328+
expectedNextDeadline,
329+
"Next deadline should be calculated using current challenge period"
330+
);
331+
});
332+
}
333+
);

0 commit comments

Comments
 (0)