Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get CLA Assistant to work nicely with branch protection #563

Closed
leondz opened this issue Mar 20, 2024 · 7 comments
Closed

get CLA Assistant to work nicely with branch protection #563

leondz opened this issue Mar 20, 2024 · 7 comments
Assignees
@jmartin-tech
Labels
bug Something isn't working housekeeping Repository and project maintenance
Milestone
release 0.9.1

Comments

@leondz
Copy link
Collaborator

leondz commented Mar 20, 2024

CLA Assistant tries, as-is, to update signatures via main. This isn't possible when branch protection is on, giving a bumpy committer experience.
@leondz leondz added the bug Something isn't working label Mar 20, 2024
@leondz leondz added this to the release 0.9.1 milestone Mar 24, 2024
@leondz leondz modified the milestones: release 0.9.1, rel Apr 21, 2024
@leondz
Copy link
Collaborator Author

leondz commented Apr 21, 2024

see also contributor-assistant/github-action#150

@leondz leondz modified the milestones: rel, release 0.9.1 Apr 23, 2024
@leondz
Copy link
Collaborator Author

leondz commented Apr 24, 2024

main now no longer requires a PR before merging

@leondz
Copy link
Collaborator Author

leondz commented Apr 24, 2024

@jmartin-tech is this best closed for now as resolved/wontfix?

@sumanth-lingappa
Copy link

what resolution have you found @leondz ?

@leondz
Copy link
Collaborator Author

leondz commented Apr 24, 2024

what resolution have you found @leondz ?

#563 (comment)

@leondz leondz added the housekeeping Repository and project maintenance label Apr 25, 2024
@sumanth-lingappa
Copy link

I didn't understand the resolution you found. Can you please help me understand?

@leondz
Copy link
Collaborator Author

leondz commented Apr 29, 2024 •
edited
Loading

we decided removing main branch protection was the best way forward for us, compared to the alternatives & the degree of automated access needed for them

@leondz leondz closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartin-tech jmartin-tech

Labels
bug Something isn't working housekeeping Repository and project maintenance
Projects
None yet
Milestone
release 0.9.1
Development

No branches or pull requests
3 participants
@leondz @jmartin-tech @sumanth-lingappa