-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reordering chapters #2553
Comments
As we are going to reach to this task relatively soon, it would be nice to hear feedback on this as well. |
I would suggest:
I think these make sense as an early and important concern, to me dealing with bad content comes afterwards.
These seem logically connected to the AuthN/AuthZ chapters and therefore it seems silly to split them.
These are super important, especially as input validation is now in V11 so I think these make sense to come next.
Lots of important things ended up in V50 and I agree that V13 has strong links to V50.
Makes sense for these to be together. I think V6 and V9 should be next to each other as they deal in similar concepts and then V8 is almost like the application of the theory defined in V6 and maybe in V9.
I am less opinionated about these ones. |
@jmanico @danielcuthbert what do you think? |
Few comments for reasoning behind initial proposal.
Logic behind "Validation and output" first is - if you have an SQL injection, it does not matter too much how secure is your authentication. Whatever scanner, every script-kiddie etc start from collecting low-hanging fruits from that field. Syntax first, logic later.
Not that silly, as those are even more logically connected to API and services. |
Depends whether the SQLi is in authentication functionality or not :) Authentication still feels to to me like a high risk area to tackle at the first stage.
I am not sure they are more connected to API and services and I definitely don't think they are more connected than the rest of the authentication/session management/access control chapters which are also very connected to API and services. |
Full structure as it stands for BE:
|
Proposal for in-chapter reorder V3
V5
V6 just based on the L1 requirements in sections
Q: can the title for V6.2 be more specific? V9
V10
V11
V13
V14
V50
|
Opened #2790. I think with that name, it should be the 2nd section in V6. Otherwise, no objections to the order above. |
A few suggestions: v5 V5.6 Validation and Sanitization Architecture Note: Just putting sanitization before injection for the same reason we put validation first. v6 V1.6 Cryptographic Inventory and Documentation Note: Putting primitives up front in this list v9 V9.4 General TLS Security Guidance Note: Putting External (which is more important) up front v14 V14.1 Configuration Documentation Note: This re-ordering reflects a typical deployment pipeline a bit better v50 V1.50 Web Frontend Security Documentation Notes: I think this better reflects order of importance of these modules The rest of the suggestions above look great to me. :) |
So, just after those got changed :) V6 and V9 I leave Josh to decide, for V5, V14 and V50 I obviously had different opinion and disagree with some of the proposed reasoning. We will go through this list tomorrow to decide order for chapters, so if you have really good arguments to provide to have any changes, then we can redecide. |
I am sorry I was on vacation last week and am just catching up. I explained my reasoning in the "notes" section at the end of each section. These are just my opinions Elar, and I'm really ok if you take a different path. |
Josh and Elar had a discussion about chapter order and this is where we came down (for sections, a PR was already merged so let's open additional issues if necessary):
Rationale:
|
ping @jmanico @randomstuff - the earliest I'll get your feedback the better it is. This decision is at the moment a blocker to move forward with #2456 |
I think all of your suggestions here have been reasonable and I do not have a big charge over this. I think you should move forward with this as you see fit. |
PR #2803
|
This is great work @elarlang - so much cleaner. Nice job! 🥳 |
Edit: used proposal with reasons: #2553 (comment)
To have some future step happening faster - we need to think about the order for the chapters.
Proposal for some kind of grouping and order:
V11 Business Logic
V5
Validation,Sanitization and EncodingV2 Authentication
V3 Session Management
V4 Access Control
V50 Web Frontend Security
V13 API and Web Service
V52 Self-contained Tokens
V51 OAuth and OIDC
V6 Cryptography
V8 Data Protection
V9 Secure Communication
V10 Secure Coding Architecture and Implementation
V12 File and Resources - some sections are fitting to be next to input validation, some with next to configuration
V7 Security Logging and Error Handling
V14 Configuration
V53 WebRTC
The text was updated successfully, but these errors were encountered: