Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Business Logic chapter #2797

Closed
tghosth opened this issue Mar 27, 2025 · 8 comments
Closed

Rename Business Logic chapter #2797

tghosth opened this issue Mar 27, 2025 · 8 comments

Comments

@tghosth
Copy link
Collaborator

tghosth commented Mar 27, 2025

This chapter now contains a large section on input validation which probably deserves recognition.

Having discussed with Elar, our best suggestion for now is "V11 Functional and Logical Validation"

Any other ideas?

@tghosth tghosth added 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet V2 (prev V11) _5.0 - rc1 labels Mar 27, 2025
@jmanico
Copy link
Member

jmanico commented Mar 27, 2025

Since we still have a prominent business logic section in v11, how about "V11: Business Logic & Validation Controls" or "V11: Validation Controls & Business Logic"?

@tghosth
Copy link
Collaborator Author

tghosth commented Mar 27, 2025

So we had vague thoughts around the concept of business logic and whether it is really just functional validation but I take your point that we call it business logic in the chapter itself and therefore just making a change in the heading might be confusing.

Maybe we should simplify to "V11: Validation & Business Logic"?

@tghosth
Copy link
Collaborator Author

tghosth commented Mar 27, 2025

@elarlang

@jmanico
Copy link
Member

jmanico commented Mar 27, 2025

Maybe we should simplify to "V11: Validation & Business Logic"?

I like it.

@elarlang
Copy link
Collaborator

elarlang commented Mar 27, 2025

Maybe we should simplify to "V11: Validation & Business Logic"?

I'm ok with "Validation and Business Logic"

Although, from time-to-time I point out, that the "business" in "business logic" can be misleading, basically it is just "logic".

So one option is:
"Input and logic validation".

@jmanico
Copy link
Member

jmanico commented Mar 27, 2025

I agree "business logic" is very misleading, but its a fairly standard term in appsec. I worry just "logic" alone does not convey the deeper meaning we are trying to get through to folks.

@tghosth
Copy link
Collaborator Author

tghosth commented Mar 30, 2025

I think business logic is so widely used I don't want to try and fight against so let's go with "Validation & Business Logic"

@tghosth tghosth added 6) PR awaiting review and removed 1) Discussion ongoing Issue is opened and assigned but no clear proposal yet labels Mar 30, 2025
@jmanico
Copy link
Member

jmanico commented Mar 30, 2025

I think business logic is so widely used I don't want to try and fight against so let's go with "Validation & Business Logic"

I think this is a good call, Josh. 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants