feat: [sc-12048] 🧶 [frontend] Make bundle smaller (#2911)

Co-authored-by: Jakub Swierczek <jakub.swierczek@outlook.com>

Author: marcinciarka

.codesandbox/Dockerfile

@@ -1 +1 @@
-FROM node:16.20.0
+FROM node:18.12

.github/workflows/build.yml

@@ -18,7 +18,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18.12
       - uses: actions/cache@v3
         id: yarn-cache
         with:
@@ -41,7 +41,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18.12
       - uses: actions/cache@v3
         id: yarn-cache
         with:
@@ -64,7 +64,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18.12
       - uses: actions/cache@v3
         id: yarn-cache
         with:
@@ -90,7 +90,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18.12
       - uses: actions/cache@v3
         id: yarn-cache
         with:

.github/workflows/dev-cache.yaml

@@ -13,7 +13,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18.12
       - uses: actions/cache@v3
         id: yarn-cache
         with:

.github/workflows/release.yaml

@@ -32,7 +32,7 @@ jobs:
           fetch-depth: 0
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18.12
       - name: 'Determine Release Type'
         run: |
           if ${{ contains(github.event.inputs.release_type, 'major') }}; then

.nvmrc

@@ -1 +1 @@
-16.20.0
+18.12

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:16.20.0
+FROM node:18.12
 
 EXPOSE 3000
 

blockchain/TokenConfig.ts

@@ -1,3 +1,4 @@
+import type { IconProps } from 'components/Icon.types'
 import type { ElementOf } from 'ts-essentials'
 
 export const COIN_TAGS = ['stablecoin', 'lp-token'] as const
@@ -9,14 +10,12 @@ export interface TokenConfig {
   digits: number
   maxSell?: string
   name: string
-  icon: string
-  iconCircle: string
+  icon: IconProps['icon']
+  iconCircle: IconProps['icon']
   coinpaprikaTicker?: string
   coinpaprikaFallbackTicker?: string
   tags: CoinTag[]
   color: string
-  bannerIcon: string
-  bannerGif: string
   token0?: string
   token1?: string
   coinbaseTicker?: string

blockchain/calls/proxyActions/proxyActionsResolver.test.ts

@@ -6,13 +6,6 @@ import { proxyActionsAdapterResolver$ } from './proxyActionsAdapterResolver'
 
 describe('proxyActionsAdapterResolver', () => {
   describe('crate from ilk (open new vault)', () => {
-    it('returns a cropjoin proxy actions for CRVV1ETHSTETH-A ilk', () => {
-      const adapter$ = proxyActionsAdapterResolver$({ ilk: 'CRVV1ETHSTETH-A' })
-
-      const state = getStateUnpacker(adapter$)
-
-      expect(state().AdapterType).toBe(ProxyActionsAdapterType.CROPJOIN)
-    })
     it('returns default proxy actions for other ilks', () => {
       const adapter$ = proxyActionsAdapterResolver$({ ilk: 'ETH-A' })
 

blockchain/contracts/arbitrum.ts

@@ -67,8 +67,7 @@ export const arbitrumContracts: MainnetContractsWithOptional = {
       arbitrum.maker.joins,
       supportedIlks.filter(
         // these are not supported on goerli
-        (ilk) =>
-          !['CRVV1ETHSTETH-A', 'GUNIV3DAIUSDC1-A', 'GUNIV3DAIUSDC2-A', 'GNO-A'].includes(ilk),
+        (ilk) => !['GUNIV3DAIUSDC1-A', 'GUNIV3DAIUSDC2-A', 'GNO-A'].includes(ilk),
       ),
     ),
   },

blockchain/contracts/goerli.ts

@@ -72,8 +72,7 @@ export const goerliContracts: MainnetContractsWithOptional = {
       goerli.maker.joins,
       supportedIlks.filter(
         // these are not supported on goerli
-        (ilk) =>
-          !['CRVV1ETHSTETH-A', 'GUNIV3DAIUSDC1-A', 'GUNIV3DAIUSDC2-A', 'GNO-A'].includes(ilk),
+        (ilk) => !['GUNIV3DAIUSDC1-A', 'GUNIV3DAIUSDC2-A', 'GNO-A'].includes(ilk),
       ),
     ),
   },

blockchain/contracts/optimism.ts

@@ -77,8 +77,7 @@ export const optimismContracts: OptimismContracts = {
       optimism.maker.joins,
       supportedIlks.filter(
         // these are not supported on goerli
-        (ilk) =>
-          !['CRVV1ETHSTETH-A', 'GUNIV3DAIUSDC1-A', 'GUNIV3DAIUSDC2-A', 'GNO-A'].includes(ilk),
+        (ilk) => !['GUNIV3DAIUSDC1-A', 'GUNIV3DAIUSDC2-A', 'GNO-A'].includes(ilk),
       ),
     ),
   },

blockchain/ens.ts

@@ -4,7 +4,8 @@ import type { Observable } from 'rxjs'
 import { switchMap } from 'rxjs/operators'
 
 import type { Context } from './network.types'
-import { getNetworkRpcEndpoint, NetworkIds } from './networks'
+import { NetworkIds } from './networks'
+import { getNetworkRpcEndpoint } from './networks/get-network-rpc-endpoint'
 
 export function resolveENSName$(context$: Observable<Context>, address: string) {
   return context$.pipe(

blockchain/network.ts

@@ -23,7 +23,8 @@ import Web3 from 'web3'
 
 import { every5Seconds$ } from './network.constants'
 import type { Context, ContextConnected, EveryBlockFunction$ } from './network.types'
-import { getNetworkRpcEndpoint, NetworkIds, networksById } from './networks'
+import { NetworkIds, networksById } from './networks'
+import { getNetworkRpcEndpoint } from './networks/get-network-rpc-endpoint'
 
 export function createContext$(
   web3ContextConnected$: Observable<Web3ContextConnected | Web3ContextConnectedReadonly>,

blockchain/networks/get-network-rpc-endpoint.ts

@@ -0,0 +1,16 @@
+import { forkSettings } from './forks-config'
+import { isForkSetForNetworkId } from './is-fork-set-for-network-id'
+import type { NetworkIds } from './network-ids'
+import { networksById } from './networks-config'
+
+export function getNetworkRpcEndpoint(networkId: NetworkIds) {
+  const isForkSet = isForkSetForNetworkId(networkId)
+  if (!networksById[networkId]) {
+    throw new Error('Invalid contract chain id provided or not implemented yet')
+  }
+  if (isForkSet) {
+    const networkName = networksById[networkId].name
+    return forkSettings[networkName]!.url
+  }
+  return networksById[networkId].rpcUrl
+}

blockchain/networks/get-rpc-provider.ts

@@ -1,5 +1,5 @@
 import { ethers } from 'ethers'
-import { getRpcNode } from 'pages/api/rpc'
+import { getRpcNode } from 'helpers/getRpcNode'
 
 import { networkSetById } from './network-helpers'
 import type { NetworkIds } from './network-ids'

blockchain/networks/is-fork-set-for-network-id.ts

@@ -0,0 +1,8 @@
+import { forkSettings } from './forks-config'
+import type { NetworkIds } from './network-ids'
+import { networksById } from './networks-config'
+
+export const isForkSetForNetworkId = (networkId: NetworkIds) => {
+  const networkName = networksById[networkId]?.name
+  return forkSettings[networkName] !== undefined
+}

blockchain/networks/network-helpers.ts

@@ -2,6 +2,7 @@ import { keyBy } from 'lodash'
 import { env } from 'process'
 
 import { forkNetworks, forkSettings } from './forks-config'
+import { isForkSetForNetworkId } from './is-fork-set-for-network-id'
 import type { NetworkIds } from './network-ids'
 import type { NetworkConfig, NetworkConfigHexId } from './networks-config'
 import { networks, networksById } from './networks-config'
@@ -37,11 +38,6 @@ export const isTestnetNetworkHexId = (networkHexId: NetworkConfigHexId) => {
     .includes(networkHexId)
 }
 
-export const isForkSetForNetworkId = (networkId: NetworkIds) => {
-  const networkName = networksById[networkId]?.name
-  return forkSettings[networkName] !== undefined
-}
-
 const networksWithForksAtTheBeginning: NetworkConfig[] = [...forkNetworks, ...networks]
 
 const networksSet = networksWithForksAtTheBeginning.reduce((acc, network) => {
@@ -138,18 +134,6 @@ export const filterNetworksAccordingToSavedNetwork =
     return isTestnetNetworkHexId(customNetworkHexId) ? network.testnet : !network.testnet
   }
 
-export function getNetworkRpcEndpoint(networkId: NetworkIds) {
-  const isForkSet = isForkSetForNetworkId(networkId)
-  if (!networksById[networkId]) {
-    throw new Error('Invalid contract chain id provided or not implemented yet')
-  }
-  if (isForkSet) {
-    const networkName = networksById[networkId].name
-    return forkSettings[networkName]!.url
-  }
-  return networksById[networkId].rpcUrl
-}
-
 export function getNetworkById(networkId: NetworkIds) {
   const base = networkSetById[networkId]
   if (!base) {

blockchain/readOnlyEnhancedProviderProxy.ts

@@ -5,7 +5,7 @@ import { includes } from 'lodash'
 import type { JsonRpcResponse } from 'web3-core-helpers'
 
 import { JsonRpcBatchProvider } from './jsonRpcBatchProvider'
-import { getNetworkRpcEndpoint } from './networks'
+import { getNetworkRpcEndpoint } from './networks/get-network-rpc-endpoint'
 
 function fixChainId(chainId: string | number) {
   return Number(chainId).valueOf()