Modernize AppVeyor CI.

Author: PureKrome

appveyor.yml

@@ -1,17 +1,18 @@
 
 version: '{build}.0.0-dev'
-configuration: Release
-os: Visual Studio 2017
+image: Ubuntu
 pull_requests:
   do_not_increment_build_number: true
 
-environment:
-  nuget_apiKey:
-    secure: jfcUvHZhgnUboplqTBDWr8mG5PIlrgBv5TA2fhhop4ZSiDxskyy+RtYyeHoduJFR
-  myget_apiKey:
-    secure: AguzfXNvHBkkDebTyWHK7o9OC5YL3eszT6u7PnzGq2G7ozdUypDlGGpcFsTRYHEc
-  codecov_token:
-    secure: UD/jw4jCH/TAuRNJWznzounpSWdObRskb3g8AKHK7f0gk5uD9ecAvJbiSp32a+LN
+
+matrix:
+  fast_finish: true
+
+
+configuration:
+  - Debug
+  - Release
+
 
 # Override the 'version' if this is a GH-tag-commit -or- this is a custom branch (i.e not 'master').
 init:
@@ -23,48 +24,72 @@ init:
       }
       iex ((new-object net.webclient).DownloadString('https://gist.githubusercontent.com/PureKrome/0f79e25693d574807939/raw/f5b40256fc2ca77d49f1c7773d28406152544c1e/appveyor-build-info.ps'))
 
+
 before_build:
   # Display .NET Core version
-  - cmd: dotnet --info
-  # Install Codecov prerequisite
-  - choco install opencover.portable
-  - choco install codecov
-  # Display minimal restore text
-  - cmd: dotnet restore --verbosity quiet
+  - ps: dotnet --info
+
 
 build_script:
-  - dotnet build -c %CONFIGURATION% -v minimal /p:Version=%APPVEYOR_BUILD_VERSION% /p:DebugType=full --no-restore
+  - ps: dotnet restore --verbosity quiet
+  - ps: dotnet build -c $env:CONFIGURATION -v minimal /p:Version=$env:APPVEYOR_BUILD_VERSION --no-restore
+
 
 test_script:
-  - OpenCover.Console.exe -register:user -target:"dotnet.exe" -targetargs:"test tests\OpenRealEstate.Transmorgrifiers.RealestateComAu.Tests -c %CONFIGURATION% -v minimal --no-restore --no-build " -filter:"+[OpenRealEstate.*]* -[OpenRealEstate.*.Tests]*" -output:".\coverage.xml" -oldstyle
+  - ps: |
+      if ($env:CONFIGURATION -eq 'Debug')
+      {
+          dotnet test -c $env:CONFIGURATION -v minimal --no-build --collect:"XPlat Code Coverage" --settings coverlet.runsettings --results-directory './CodeCoverageResults'
+      }
+      else
+      {
+          dotnet test -c $env:CONFIGURATION -v minimal --no-build
+      }
 
+
+# We only:
+#   - Send DEBUG results up to codecov.
+#   - Pack for RELEASE only.
 after_test:
-  - codecov -f "coverage.xml" -t $(codecov_token)
-  - dotnet pack -c %CONFIGURATION% /p:Version=%APPVEYOR_BUILD_VERSION% --no-restore --no-build
+  - ps: |
+      if ($env:CONFIGURATION -eq 'Debug')
+      {
+          # Currently, the bash script version is better than the .exe version.
+          Invoke-WebRequest -Uri 'https://codecov.io/bash' -OutFile codecov.sh
+          bash codecov.sh -s './CodeCoverageResults/' -f '*.xml' -Z
+      }
+      
+      if ($env:CONFIGURATION -eq 'Release')
+      {
+          dotnet pack -c $env:CONFIGURATION --include-symbols -p:SymbolPackageFormat=snupkg /p:Version=$env:APPVEYOR_BUILD_VERSION --no-build
+      }
+
+
 
 artifacts:
   - path: '**\*.nupkg'
-    name: openrealestate-nugets
+    name: nuget-packages
+    type: NuGetPackage
+  - path: '**\*.snupkg'
+    name: nuget-symbols
     type: NuGetPackage
 
+
 deploy:
   - provider: NuGet
     server: https://www.myget.org/F/openrealestate-net/api/v2/package
     api_key:
       secure: AguzfXNvHBkkDebTyWHK7o9OC5YL3eszT6u7PnzGq2G7ozdUypDlGGpcFsTRYHEc
-    skip_symbols: true
-    artifact: openrealestate-nugets
+    artifact: nuget-packages # myget does now support symbols BUT appveyor doesn't publish it correctly
     on:
-      appveyor_repo_tag: false
+      CONFIGURATION: Release
+      APPVEYOR_REPO_TAG: false
   - provider: NuGet
     server: https://www.myget.org/F/openrealestate/api/v2/package
     api_key:
       secure: AguzfXNvHBkkDebTyWHK7o9OC5YL3eszT6u7PnzGq2G7ozdUypDlGGpcFsTRYHEc
-    skip_symbols: true
-    artifact: openrealestate-nugets
+    artifact: nuget-packages # myget does now support symbols BUT appveyor doesn't publish it correctly
     on:
-      branch: master
-      appveyor_repo_tag: true
-
-cache:
-  - packages -> **\packages.config
+      CONFIGURATION: Release
+      APPVEYOR_REPO_BRANCH: master
+      APPVEYOR_REPO_TAG: true

coverlet.runsettings

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<RunSettings>
+  <DataCollectionRunSettings>
+    <DataCollectors>
+      <DataCollector friendlyName="XPlat code coverage">
+        <Configuration>
+          <Exclude>[*.Tests]*,</Exclude> <!-- [Assembly-Filter]Type-Filter -->
+        </Configuration>
+      </DataCollector>
+    </DataCollectors>
+  </DataCollectionRunSettings>
+</RunSettings>