Skip to content

Check indexed keys in event assertions (snforge migration) #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-fleming opened this issue Jul 15, 2024 · 4 comments · May be fixed by #1401
Open

Check indexed keys in event assertions (snforge migration) #1054

andrew-fleming opened this issue Jul 15, 2024 · 4 comments · May be fixed by #1401
Labels
good first issue Good for newcomers
Milestone

Comments

@andrew-fleming
Copy link
Collaborator

No description provided.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Contracts for Cairo Jul 15, 2024
@andrew-fleming andrew-fleming changed the title Check event keys in assertions (snforge migration) Check indexed keys in event assertions (snforge migration) Jul 15, 2024
@andrew-fleming andrew-fleming added this to the 4. later milestone Aug 9, 2024
@ericnordelo ericnordelo modified the milestones: 2. next, 3. after Sep 25, 2024
@andrew-fleming andrew-fleming modified the milestones: 3. after, 2. next Oct 18, 2024
@ggonzalez94 ggonzalez94 modified the milestones: 2. next, 3. after Nov 5, 2024
@ericnordelo ericnordelo modified the milestones: 3. after, 1. current Nov 25, 2024
@ericnordelo ericnordelo modified the milestones: 1. current, 2. next Jan 6, 2025
@ericnordelo ericnordelo added the good first issue Good for newcomers label Feb 11, 2025
@ericnordelo ericnordelo modified the milestones: 2. next, 1. current Mar 21, 2025
@turkaturki
Copy link

Hi @ericnordelo , could you please assign this to me? I'd like to work on it.

@ericnordelo
Copy link
Member

Hey @turkaturki. Thanks for your interest in contributing to the library. Feel free to work on this and open a PR; we will happily review it.

@turkaturki
Copy link

Hi @ericnordelo @andrew-fleming , could you please provide a bit more context regarding this issue? Thank you.

@ericnordelo
Copy link
Member

Currently, we test that events are emitted correctly for our components, and we check that the members match the expected format. The issue is that we are not testing that the indexed keys in the events are the expected ones, and if a key changes, the test suite wouldn't catch it. To address this issue we should check snforge API to see what is the best way to test this indexed keys.

@turkaturki turkaturki linked a pull request Apr 3, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

Successfully merging a pull request may close this issue.

4 participants