-
Notifications
You must be signed in to change notification settings - Fork 387
Check indexed keys in event assertions (snforge migration) #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @ericnordelo , could you please assign this to me? I'd like to work on it. |
Hey @turkaturki. Thanks for your interest in contributing to the library. Feel free to work on this and open a PR; we will happily review it. |
Hi @ericnordelo @andrew-fleming , could you please provide a bit more context regarding this issue? Thank you. |
Currently, we test that events are emitted correctly for our components, and we check that the members match the expected format. The issue is that we are not testing that the indexed keys in the events are the expected ones, and if a key changes, the test suite wouldn't catch it. To address this issue we should check snforge API to see what is the best way to test this indexed keys. |
No description provided.
The text was updated successfully, but these errors were encountered: