Move declarations from af.h into the corresponding storage/table/... headers (project-chip#32776)

* move emberAfLocateAttributeMetadata to attribute-storage.h as it is implemented in attribute-storage.cpp

* Move more methods

* Global endpoints extern should not exist

* move more things

* restyle

* Move the last bits from af.h into the corresponding headers. Remove af.h (this will cause compile issues)

* Remove all references to af.h

* Restyle and zap regen

* All-clusters now compiles on linux

* Fix ota requester compile

* Make tests compile

* Restyle

* Fix lint.yml: af.h does not exist anymore

* Fix door lock compile

* Ensure everything using emberAfEndpointEnableDisable includes endpoint-config-api

* Fix emberAfContainsServer include needs

* Include attribute-storage.h whenever kEmberinvalidEndpointIndex is defined

* Include attribute-storage.h whenever kEmberinvalidEndpointIndex is used

* Fix linter

* Another lint cleanup

* Fix all includes referencing EnabledEndpointsWithServerCluster

* Restyle

* Fix andorid tv compile

* Fix linter complain: application basic delegate was already stl-bound, add string as well

* Fix Attributes.h using emberAfWriteAttribute

* Fix dependencies on AccountLogingManager ... needs config to access SERVER_ENDPOINT_COUNT

* Add a lot of includes for std::string where std::string is used

* Fix checkincludes

* Fix one more build

* Zap regen ... some string adds were in generated code

* make android compile: fix dynamic server dependencies on attribute-storage.h

* Refactor a bit to make gn linter happy

* Restyle

* Split out attribute-storage/table into a -detail and non-detail header

* Restyle

* Fix lint typo

* Make tv app compile: need dynamic endpoints defines accessible

* Restyle

* Remove code from storage-detail

* Fix code again: FIXED_ENDPOINT_COUNT must be defined, so config has to be included

* More includes to make compile work. At least now boufallolab compiles

* Fix linux builds ... apparently mock attribute storage is a copy & paste ... this is probably not good...

* Direct include of endpoint_config in attribute-storage.h

* Minor comment update: alignment and fix typo

* Some code review comments

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>

Author: andy31415

.github/workflows/lint.yml

@@ -101,11 +101,12 @@ jobs:
                      --known-failure app/reporting/tests/MockReportScheduler.cpp \
                      --known-failure app/reporting/tests/MockReportScheduler.h \
                      --known-failure app/TestEventTriggerDelegate.h \
-                     --known-failure app/util/af.h \
                      --known-failure app/util/attribute-storage.cpp \
                      --known-failure app/util/attribute-storage.h \
+                     --known-failure app/util/attribute-storage-detail.h \
                      --known-failure app/util/attribute-table.cpp \
                      --known-failure app/util/attribute-table.h \
+                     --known-failure app/util/attribute-table-detail.h \
                      --known-failure app/util/binding-table.cpp \
                      --known-failure app/util/binding-table.h \
                      --known-failure app/util/config.h \
@@ -253,7 +254,7 @@ jobs:
             - name: Check for use of 'emberAfReadAttribute' instead of the type-safe getters
               if: always()
               run: |
-                  git grep -I -n 'emberAfReadAttribute' -- './*' ':(exclude).github/workflows/lint.yml' ':(exclude)src/app/util/af.h' ':(exclude)zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp' ':(exclude)src/app/zap-templates/templates/app/attributes/Accessors-src.zapt' ':(exclude)src/app/util/attribute-table.cpp'  && exit 1 || exit 0
+                  git grep -I -n 'emberAfReadAttribute' -- './*' ':(exclude).github/workflows/lint.yml' ':(exclude)src/app/util/attribute-table.h' ':(exclude)zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp' ':(exclude)src/app/zap-templates/templates/app/attributes/Accessors-src.zapt' ':(exclude)src/app/util/attribute-table.cpp'  && exit 1 || exit 0
 
             # git grep exits with 0 if it finds a match, but we want
             # to fail (exit nonzero) on match.  And we want to exclude this file,
@@ -263,7 +264,7 @@ jobs:
             - name: Check for use of 'emberAfWriteAttribute' instead of the type-safe setters
               if: always()
               run: |
-                  git grep -I -n 'emberAfWriteAttribute' -- './*' ':(exclude).github/workflows/lint.yml' ':(exclude)src/app/util/af.h' ':(exclude)zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp' ':(exclude)src/app/zap-templates/templates/app/attributes/Accessors-src.zapt' ':(exclude)src/app/util/attribute-table.cpp' ':(exclude)examples/common/pigweed/rpc_services/Attributes.h' ':(exclude)src/app/util/attribute-table.h' ':(exclude)src/app/util/ember-compatibility-functions.cpp' && exit 1 || exit 0
+                  git grep -I -n 'emberAfWriteAttribute' -- './*' ':(exclude).github/workflows/lint.yml' ':(exclude)zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp' ':(exclude)src/app/zap-templates/templates/app/attributes/Accessors-src.zapt' ':(exclude)src/app/util/attribute-table.cpp' ':(exclude)examples/common/pigweed/rpc_services/Attributes.h' ':(exclude)src/app/util/attribute-table.h' ':(exclude)src/app/util/ember-compatibility-functions.cpp' && exit 1 || exit 0
 
             # Run ruff python linter
             - name: Check for errors using ruff Python linter

examples/air-purifier-app/ameba/main/DeviceCallbacks.cpp

@@ -29,7 +29,6 @@
 #include <app-common/zap-generated/ids/Clusters.h>
 #include <app/CommandHandler.h>
 #include <app/server/Dnssd.h>
-#include <app/util/af.h>
 #include <app/util/basic-types.h>
 #include <app/util/util.h>
 #include <lib/dnssd/Advertiser.h>