Fixed potential divide by 0 - Update examples/energy-management-app/energy-management-common/water-heater/src/WhmDelegateImpl.cpp

jamesharrow · web-flow · commit a614aa0ed29d · 2024-08-29T22:36:49.000+01:00
diff --git a/examples/energy-management-app/energy-management-common/water-heater/src/WhmDelegateImpl.cpp b/examples/energy-management-app/energy-management-common/water-heater/src/WhmDelegateImpl.cpp
@@ -320,7 +320,7 @@ uint8_t WaterHeaterManagementDelegate::CalculateTankPercentage() const
     int32_t divisor = static_cast<int32_t>(GetActiveTargetWaterTemperature()) - static_cast<int32_t>(mColdWaterTemperature);
 
     tankPercentage = 100;
-    if (divisor >= 0)
+    if (divisor > 0)
     {
         tankPercentage = 100 * (static_cast<int32_t>(mWaterTemperature) - static_cast<int32_t>(mColdWaterTemperature)) / divisor;
     }

Original file line number	Diff line number	Diff line change
`@@ -320,7 +320,7 @@ uint8_t WaterHeaterManagementDelegate::CalculateTankPercentage() const`
`320`	`320`	`int32_t divisor = static_cast<int32_t>(GetActiveTargetWaterTemperature()) - static_cast<int32_t>(mColdWaterTemperature);`
`321`	`321`
`322`	`322`	`tankPercentage = 100;`
`323`		`- if (divisor >= 0)`
	`323`	`+ if (divisor > 0)`
`324`	`324`	`{`
`325`	`325`	`tankPercentage = 100 * (static_cast<int32_t>(mWaterTemperature) - static_cast<int32_t>(mColdWaterTemperature)) / divisor;`
`326`	`326`	`}`