Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter append_genome_prefix_to_feature_ids #137

Merged
merged 2 commits into from
Mar 9, 2025

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented Mar 5, 2025

PR checklist

  • Added parameter append_genome_prefix_to_feature_ids
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Mar 5, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 79728ef

+| ✅ 104 tests passed       |+
#| ❔  18 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: assets/nf-core-genepal_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genepal_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-genepal_logo_dark.png
  • nextflow_config - nextflow_config
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File does not exist: assets/nf-core-genepal_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genepal_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-genepal_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/genepal/genepal/.github/workflows/awstest.yml

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2025-03-05 01:59:44

@GallVp GallVp requested a review from jasonshiller March 6, 2025 00:21
@GallVp
Copy link
Member Author

GallVp commented Mar 6, 2025

Hi @jasonshiller

All the tests are passing now. Please skim through the changes and let me know if anything stands out. Once you have happy, let's merge it.

@jasonshiller jasonshiller merged commit 8f825ad into dev Mar 9, 2025
7 checks passed
@jasonshiller jasonshiller deleted the feat/append_genome_prefix_to_feature_ids branch March 9, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants