Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using 'dns' package in 'validUrls' plugin breaks Edge Deployments #601

Closed
jpulec opened this issue Sep 11, 2024 · 1 comment · Fixed by #852
Closed

Using 'dns' package in 'validUrls' plugin breaks Edge Deployments #601

jpulec opened this issue Sep 11, 2024 · 1 comment · Fixed by #852
Labels
bug Something isn't working triage

Comments

@jpulec
Copy link
Contributor

jpulec commented Sep 11, 2024

What Happened?

Description

In edge environments, like on Vercel's edge, many node APIs are not supported and cause deployments to fail. Including dns in the validUrls plugin causes this to happen.

What Should Have Happened?

Consider a different approach for DNS based url validation, or maybe find a way to better allow the code to be tree shaken in edge environments.

Relevant Code Snippet

No response

Your Twitter/LinkedIn

No response

@VisargD
Copy link
Collaborator

VisargD commented Dec 28, 2024

Hey @jpulec @noy4 - Sorry for the delay on this. We were trying to figure out a better way for cross-compatibility in general and lost track of this thread. We have removed the dns module dependency and replaced it with dns-over-http approach which should work fine in edge runtimes as well. Please let me know if you face issues with any other dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants