chore(eslint): Update ESLint configurations and fix linting scripts

Author: better-salmon

.changeset/changelog-github-custom.ts

@@ -12,13 +12,15 @@ const changelogFunctions: ChangelogFunctions = {
         'Please provide a repo to this changelog generator like this:\n"changelog": ["@changesets/changelog-github", { "repo": "org/repo" }]'
       );
     }
-    if (dependenciesUpdated.length === 0) return '';
+    if (dependenciesUpdated.length === 0) {
+      return '';
+    }
 
     const changesetLink = `- Updated dependencies [${(
       await Promise.all(
         changesets.map(async (cs) => {
           if (cs.commit) {
-            let { links } = await getInfo({
+            const { links } = await getInfo({
               repo: options.repo,
               commit: cs.commit,
             });
@@ -45,12 +47,14 @@ const changelogFunctions: ChangelogFunctions = {
 
     let prFromSummary: number | undefined;
     let commitFromSummary: string | undefined;
-    let usersFromSummary: string[] = [];
+    const usersFromSummary: string[] = [];
 
     const replacedChangelog = changeset.summary
       .replace(/^\s*(?:pr|pull|pull\s+request):\s*#?(\d+)/im, (_, pr) => {
-        let num = Number(pr);
-        if (!isNaN(num)) prFromSummary = num;
+        const num = Number(pr);
+        if (!isNaN(num)) {
+          prFromSummary = num;
+        }
         return '';
       })
       .replace(/^\s*commit:\s*([^\s]+)/im, (_, commit) => {
@@ -91,7 +95,7 @@ const changelogFunctions: ChangelogFunctions = {
       }
       const commitToFetchFrom = commitFromSummary || changeset.commit;
       if (commitToFetchFrom) {
-        let { links } = await getInfo({
+        const { links } = await getInfo({
           repo: options.repo,
           commit: commitToFetchFrom,
         });

.changeset/giant-carpets-brake.md

@@ -0,0 +1,7 @@
+---
+'create-qwik': patch
+'@builder.io/qwik-city': patch
+'@builder.io/qwik': patch
+---
+
+Fix linting errors which were previously being ignored across the monorepo.

eslint.config.js

@@ -22,23 +22,26 @@ const ignores = [
   '**/tsdoc-metadata.json',
   '**/.DS_Store',
   '**/*.mp4',
-  'scripts/**/*',
+  'scripts',
   '**/server/**/*.js',
   '**/*.tsbuildinfo',
-  'packages/docs/api/**/*',
+  'packages/docs/api',
   'packages/docs/public/repl/repl-sw.js*',
-  'packages/docs/src/routes/examples/apps/**/*',
-  'packages/docs/src/routes/playground/app/**/*',
-  'packages/docs/src/routes/tutorial/**/*',
-  'packages/qwik-labs/lib/**/*',
-  'packages/qwik-labs/lib-types/**/*',
-  'packages/qwik-labs/vite/**/*',
+  'packages/docs/src/routes/examples/apps',
+  'packages/docs/src/routes/playground/app',
+  'packages/docs/src/routes/tutorial',
+  'packages/qwik-labs/lib',
+  'packages/qwik-labs/lib-types',
+  'packages/qwik-labs/vite',
   'packages/insights/drizzle.config.ts',
   'packages/insights/panda.config.ts',
   'starters/apps/base',
   'starters/apps/library',
   'starters/templates',
   '**/vite.config.ts',
+  // packages with eslint.config.mjs
+  'packages/qwik-labs',
+  'packages/insights',
 ];
 
 export default tseslint.config(
@@ -89,6 +92,17 @@ export default tseslint.config(
       '@typescript-eslint/no-var-requires': 'off',
       curly: 'error',
       'no-new-func': 'error',
+      '@typescript-eslint/no-empty-object-type': 'off',
+      '@typescript-eslint/no-unused-expressions': 'off',
+      '@typescript-eslint/no-unsafe-function-type': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+      '@typescript-eslint/no-wrapper-object-types': 'off',
+    },
+  },
+  {
+    files: ['packages/docs/**/*.{ts,tsx}'],
+    rules: {
+      'no-console': 'off',
     },
   }
 );

package.json

@@ -226,8 +226,8 @@
     "link.dist.npm": "cd packages/qwik && npm link && cd ../qwik-city && npm link && cd ../eslint-plugin-qwik && npm link && cd ../qwik-react && npm link",
     "link.dist.yarn": "cd packages/qwik && yarn link && cd ../qwik-city && yarn link && cd ../eslint-plugin-qwik && yarn link && cd ../qwik-react && yarn link",
     "lint": "pnpm lint.eslint && pnpm lint.prettier && pnpm lint.rust",
-    "lint.eslint": "eslint --cache \"**/*.ts*\"",
-    "lint.fix": "eslint --fix \"**/*.ts*\" && pnpm prettier.fix",
+    "lint.eslint": "eslint --cache \"**/*.ts*\" && pnpm -r --parallel lint",
+    "lint.fix": "eslint --fix \"**/*.ts*\" && pnpm -r --parallel lint.fix && pnpm prettier.fix",
     "lint.prettier": "prettier --cache --check .",
     "lint.rust": "make lint",
     "lint.syncpack": "syncpack list-mismatches",

packages/create-qwik/index.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import { runCreateCli } from './src/run-create-cli';
 import { runCreateInteractiveCli } from './src/run-create-interactive-cli';
 import { panic, printHeader } from '../qwik/src/cli/utils/utils';

packages/create-qwik/src/run-create-interactive-cli.ts

@@ -7,7 +7,7 @@ import { join, relative } from 'node:path';
 import type { CreateAppResult } from '../../qwik/src/cli/types';
 import { clearDir } from './helpers/clearDir';
 import { createApp } from './create-app';
-/* eslint-disable no-console */
+
 import fs from 'node:fs';
 import { getRandomJoke } from './helpers/jokes';
 import { installDepsCli } from './helpers/installDepsCli';

packages/docs/codesandbox.sync.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import { readdirSync, readFileSync, writeFileSync } from 'node:fs';
 import { join } from 'node:path';
 

packages/docs/contributors.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import { fetch } from 'undici';
 import fs from 'node:fs';
 import path from 'node:path';

packages/docs/src/components/router-head/router-head.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import { component$ } from '@builder.io/qwik';
 import { useDocumentHead, useLocation } from '@builder.io/qwik-city';
 import { Social } from './social';

packages/docs/src/repl/repl-version.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import { QWIK_PKG_NAME, bundled } from './bundled';
 
 const bundledVersion = bundled[QWIK_PKG_NAME].version;

packages/docs/src/repl/repl.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import {
   component$,
   noSerialize,

packages/docs/src/repl/worker/app-bundle-client.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import type { InputOptions, OutputAsset, OutputChunk } from 'rollup';
 import type { Diagnostic, QwikRollupPluginOptions } from '@builder.io/qwik/optimizer';
 import type { ReplInputOptions, ReplModuleOutput, ReplResult } from '../types';

packages/docs/src/repl/worker/app-bundle-ssr.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import type { InputOptions } from 'rollup';
 import type { Diagnostic, QwikRollupPluginOptions } from '@builder.io/qwik/optimizer';
 import type { ReplInputOptions, ReplResult } from '../types';

packages/docs/src/repl/worker/app-ssr-html.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import type { RenderOptions, RenderToStringResult } from '@builder.io/qwik/server';
 import type { ReplInputOptions, ReplResult } from '../types';
 import type { QwikWorkerGlobal } from './repl-service-worker';

packages/docs/src/repl/worker/app-update.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import type { ReplInputOptions, ReplResult } from '../types';
 import { appBundleClient } from './app-bundle-client';
 import { appBundleSsr } from './app-bundle-ssr';

packages/docs/src/repl/worker/repl-dependencies.ts

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import type { ReplInputOptions } from '../types';
 import { QWIK_PKG_NAME, QWIK_REPL_DEPS_CACHE } from './repl-constants';
 import type { QwikWorkerGlobal } from './repl-service-worker';

packages/docs/src/repl/worker/repl-server.ts

@@ -5,7 +5,6 @@
  * - Public static html source file: "public/repl/~repl-server-host.html"
  */
 
-/* eslint-disable no-console */
 import type { ReplMessage, ReplResult } from '../types';
 
 export const initReplServer = (win: Window, doc: Document, nav: Navigator) => {

packages/docs/src/routes/community/layout.tsx

@@ -6,7 +6,6 @@ import { OnThisPage } from '../../components/on-this-page/on-this-page';
 import { ContentNav } from '../../components/content-nav/content-nav';
 import styles from '../docs/docs.css?inline';
 
-// eslint-disable-next-line
 export { useMarkdownItems } from '../../components/sidebar/sidebar';
 
 export default component$(() => {

packages/docs/src/routes/demo/cookbook/drag&drop/advanced/index.tsx

@@ -53,7 +53,9 @@ export default component$(() => {
                 const targetId = parseInt(
                   (e.target as HTMLDivElement).dataset.id || '0'
                 );
-                if (targetId === 0) return;
+                if (targetId === 0) {
+                  return;
+                }
 
                 const targetIndex = items1.value.findIndex(
                   (i) => i.id === targetId
@@ -68,7 +70,9 @@ export default component$(() => {
                   items1.value = newItems;
                 } else {
                   // Sorting between containers
-                  if (!item) return;
+                  if (!item) {
+                    return;
+                  }
                   items2.value = items2.value.filter((i) => i.id !== itemId);
                   insertElement(newItems, targetIndex, item);
                   items1.value = newItems;
@@ -133,7 +137,9 @@ export default component$(() => {
                 const targetId = parseInt(
                   (e.target as HTMLDivElement).dataset.id || '0'
                 );
-                if (targetId === 0) return;
+                if (targetId === 0) {
+                  return;
+                }
                 const newItems = [...items2.value];
                 const draggedIndex = items2.value.findIndex(
                   (i) => i.id === itemId
@@ -147,7 +153,9 @@ export default component$(() => {
                   items2.value = newItems;
                 } else {
                   // Sorting between containers
-                  if (!item) return;
+                  if (!item) {
+                    return;
+                  }
                   items1.value = items1.value.filter((i) => i.id !== itemId);
                   insertElement(newItems, targetIndex, item);
                   items2.value = newItems;

packages/docs/src/routes/demo/cookbook/portal/portal-provider.tsx

@@ -98,7 +98,6 @@ export const WrapJsxInContext = component$<{
   contexts: Array<ContextPair<any>>;
 }>(({ jsx, contexts }) => {
   contexts.forEach(({ id, value }) => {
-    // eslint-disable-next-line
     useContextProvider(id, value);
   });
   return (

packages/docs/src/routes/demo/eslint.config.js

@@ -1,5 +1,5 @@
 // @ts-nocheck
-/* eslint-disable @typescript-eslint/no-unused-vars */
+
 import { $, component$, type QRL } from '@builder.io/qwik';
 import { routeLoader$ } from '@builder.io/qwik-city';
 import type { InitialValues, SubmitHandler } from '@modular-forms/qwik';

packages/docs/src/routes/demo/integration/modular-forms/index.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-console */
 import { component$, Slot } from '@builder.io/qwik';
 import { useStyles$ } from '@builder.io/qwik';
 import STYLES from './demo-reset.css?inline';
@@ -21,6 +20,7 @@ function logQSymbols() {
   const consoleUl = document.getElementById('console')!;
   consoleUl.className = 'console';
   consoleUl.innerHTML = '<h1>Console</h1>';
+  // eslint-disable-next-line no-constant-binary-expression
   false &&
     document.addEventListener('qsymbol', (e) => {
       const detail = (e as any as { detail: { symbol: string } }).detail;

packages/docs/src/routes/demo/layout.tsx

@@ -1,4 +1,5 @@
 /** @jsxImportSource react */
+
 import { type ReactNode } from 'react';
 import { qwikify$ } from '@builder.io/qwik-react';
 

packages/docs/src/routes/demo/react/children/react.tsx

@@ -1,4 +1,5 @@
 /** @jsxImportSource react */
+
 import { qwikify$ } from '@builder.io/qwik-react';
 import { useState } from 'react';
 

packages/docs/src/routes/demo/react/counter-simple-hover/react.tsx

@@ -1,4 +1,5 @@
 /** @jsxImportSource react */
+
 import { qwikify$ } from '@builder.io/qwik-react';
 import { type ReactNode } from 'react';
 

packages/docs/src/routes/demo/react/counter-two-islands-host/react.tsx

@@ -1,4 +1,5 @@
 /** @jsxImportSource react */
+
 import { qwikify$ } from '@builder.io/qwik-react';
 
 function Button({ onClick }: { onClick: () => void }) {

packages/docs/src/routes/demo/react/counter-two-islands/react.tsx

@@ -1,4 +1,5 @@
 /** @jsxImportSource react */
+
 import { qwikify$ } from '@builder.io/qwik-react';
 import Tabs from '@mui/material/Tabs';
 import Tab from '@mui/material/Tab';

packages/docs/src/routes/demo/react/mui/react.tsx

@@ -47,7 +47,9 @@ export const HoverProvider = component$(() => {
             new CustomEvent('hover', {
               bubbles: true,
               detail: async (jsx: JSXOutput) => {
-                if (state.close) return;
+                if (state.close) {
+                  return;
+                }
                 state.currentTarget = e.target as HTMLElement;
                 state.close = noSerialize(await portal('popup', jsx));
               },