Fix incorrect user online private message string (CnCNet#506)

pure-scum · SadPencil · commit bc9898f638ab · 2024-10-05T02:03:58.000+08:00
* Fix incorrect user online private message string Wrong message being displayed in private messages when user comes back online. * Add "search all maps" toggle to game lobby Based off @devo1929 CnCNet#328. This PR adds a checkbox. Another PR will be made to cncnet-yr-client-package with the layout information. * Revert "Add "search all maps" toggle to game lobby" This reverts commit a33d00b.
diff --git a/DXMainClient/DXGUI/Multiplayer/CnCNet/PrivateMessagingWindow.cs b/DXMainClient/DXGUI/Multiplayer/CnCNet/PrivateMessagingWindow.cs
@@ -314,7 +314,7 @@ private void ConnectionManager_UserAdded(object sender, UserEventArgs e)
 
             if (pmUser != null)
             {
-                joinMessage = new ChatMessage(string.Format("{0} is now offline.".L10N("Client:Main:PlayerOffline"), e.User.Name));
+                joinMessage = new ChatMessage(string.Format("{0} is now online.".L10N("Client:Main:PlayerOnline"), e.User.Name));
                 pmUser.Messages.Add(joinMessage);
             }
 

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,7 @@ private void ConnectionManager_UserAdded(object sender, UserEventArgs e)`
`314`	`314`
`315`	`315`	`if (pmUser != null)`
`316`	`316`	`{`
`317`		`- joinMessage = new ChatMessage(string.Format("{0} is now offline.".L10N("Client:Main:PlayerOffline"), e.User.Name));`
	`317`	`+ joinMessage = new ChatMessage(string.Format("{0} is now online.".L10N("Client:Main:PlayerOnline"), e.User.Name));`
`318`	`318`	`pmUser.Messages.Add(joinMessage);`
`319`	`319`	`}`
`320`	`320`