Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests #115

Closed
jzvikart opened this issue Dec 16, 2024 · 2 comments
Closed

Fix integration tests #115

jzvikart opened this issue Dec 16, 2024 · 2 comments
Assignees
@jzvikart

Comments

@jzvikart
Copy link
Collaborator

Integration tests are still failing, despite lockfile being fixed now. See workflows on this PR: elizaOS#1120

It seems that somebody completely changed the test logic after we implemented it. We should either revert it or (better) ask the person who made the changes why the original version didn't work for them.
@jzvikart jzvikart assigned pgoos and jzvikart and unassigned pgoos Dec 16, 2024
@jzvikart
Copy link
Collaborator Author

The current assumption is that the tests were failing because 20s wait time for the server to start was too short. In a new PR we implemented an adaptive wait that periodically checks if the server is already running.

@jzvikart
Copy link
Collaborator Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzvikart jzvikart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pgoos @jzvikart