Fix C++20-incompatible instances of aggregate initialization (#23911)

mspang · web-flow · commit 0b8ecc849d9e · 2022-12-05T13:51:59.000-08:00
In C++20, types that declare or delete any constructors are no longer
aggregates, breaking compilation of many existing uses of aggregate
initialization.

Fix this for EmberBindingTableEntry by removing the explicitly defaulted
constructor.
diff --git a/src/app/util/types_stub.h b/src/app/util/types_stub.h
@@ -451,8 +451,6 @@ enum
  */
 struct EmberBindingTableEntry
 {
-    EmberBindingTableEntry() = default;
-
     static EmberBindingTableEntry ForNode(chip::FabricIndex fabric, chip::NodeId node, chip::EndpointId localEndpoint,
                                           chip::EndpointId remoteEndpoint, chip::Optional<chip::ClusterId> cluster)
     {

Original file line number	Diff line number	Diff line change
`@@ -451,8 +451,6 @@ enum`
`451`	`451`	`*/`
`452`	`452`	`struct EmberBindingTableEntry`
`453`	`453`	`{`
`454`		`- EmberBindingTableEntry() = default;`
`455`		`-`
`456`	`454`	`static EmberBindingTableEntry ForNode(chip::FabricIndex fabric, chip::NodeId node, chip::EndpointId localEndpoint,`
`457`	`455`	`chip::EndpointId remoteEndpoint, chip::Optional<chip::ClusterId> cluster)`
`458`	`456`	`{`