Removed InitCompleteCallback, ensured that failures in Init will get an error trace

Author: lpbeliveau-silabs

examples/lighting-app/silabs/src/AppTask.cpp

@@ -103,7 +103,6 @@ CHIP_ERROR AppTask::AppInit()
 #endif // QR_CODE_ENABLED
 #endif
 
-    BaseApplication::InitCompleteCallback(err);
     return err;
 }
 

examples/platform/silabs/BaseApplication.cpp

@@ -306,18 +306,21 @@ CHIP_ERROR BaseApplication::Init()
     {
         SILABS_LOG("BaseInit() failed");
         appError(err);
-        return err;
     }
 
-    err = AppInit();
+    if (err == CHIP_NO_ERROR)
+    {
+        err = AppInit();
+    }
+
     if (err != CHIP_NO_ERROR)
     {
         SILABS_LOG("AppInit() failed");
         appError(err);
-        return err;
     }
 
-    InitCompleteCallback(err);
+    SILABS_TRACE_END_ERROR(TimeTraceOperation::kAppInit, err);
+    SILABS_TRACE_END_ERROR(TimeTraceOperation::kBootup, err);
     return err;
 }
 
@@ -403,12 +406,6 @@ CHIP_ERROR BaseApplication::BaseInit()
     return err;
 }
 
-void BaseApplication::InitCompleteCallback(CHIP_ERROR err)
-{
-    SILABS_TRACE_END(TimeTraceOperation::kAppInit);
-    SILABS_TRACE_END(TimeTraceOperation::kBootup);
-}
-
 void BaseApplication::FunctionTimerEventHandler(void * timerCbArg)
 {
     AppEvent event;

examples/platform/silabs/BaseApplication.h

@@ -181,14 +181,6 @@ class BaseApplication
     CHIP_ERROR BaseInit();
     virtual CHIP_ERROR AppInit() { return CHIP_NO_ERROR; }
 
-    /** @brief
-     * Function to be called at the end of Init to indicate that the application has completed its initialization.
-     * Currently only used for tracing, might want to move logging here as well in the future
-     * @param err CHIP_NO_ERROR on success, corresponding error code on Init failure, note that Init failure leads to an app error
-     * so this is purely to have a trace logged with the error code
-     */
-    void InitCompleteCallback(CHIP_ERROR err);
-
     /**
      * @brief Function called to start the function timer
      *