Addressed review comments

Author: arun-silabs

src/platform/silabs/NetworkCommissioningWiFiDriver.cpp

@@ -263,17 +263,10 @@ chip::BitFlags<WiFiSecurity> SlWiFiDriver::ConvertSecuritytype(wfx_sec_t securit
     return securityType;
 }
 
-bool SlWiFiDriver::StartScanWiFiNetworks(ByteSpan ssid)
+CHIP_ERROR SlWiFiDriver::StartScanWiFiNetworks(ByteSpan ssid)
 {
     ChipLogProgress(DeviceLayer, "Start Scan WiFi Networks");
-
-    CHIP_ERROR err = wfx_start_scan(ssid, OnScanWiFiNetworkDone);
-    if (err != CHIP_NO_ERROR)
-    {
-        ChipLogError(DeviceLayer, "wfx_start_scan failed : %s", chip::ErrorStr(err));
-        return false;
-    }
-    return true;
+    return wfx_start_scan(ssid, OnScanWiFiNetworkDone);
 }
 
 void SlWiFiDriver::OnScanWiFiNetworkDone(wfx_wifi_scan_result_t * aScanResult)
@@ -318,7 +311,7 @@ void SlWiFiDriver::ScanNetworks(ByteSpan ssid, WiFiDriver::ScanCallback * callba
     if (callback != nullptr)
     {
         mpScanCallback = callback;
-        if (!StartScanWiFiNetworks(ssid))
+        if (StartScanWiFiNetworks(ssid) != CHIP_NO_ERROR)
         {
             ChipLogError(DeviceLayer, "ScanWiFiNetworks failed to start");
             mpScanCallback = nullptr;

src/platform/silabs/NetworkCommissioningWiFiDriver.h

@@ -134,7 +134,7 @@ class SlWiFiDriver final : public WiFiDriver
 
 private:
     bool NetworkMatch(const WiFiNetwork & network, ByteSpan networkId);
-    bool StartScanWiFiNetworks(ByteSpan ssid);
+    CHIP_ERROR StartScanWiFiNetworks(ByteSpan ssid);
     static void OnScanWiFiNetworkDone(wfx_wifi_scan_result_t * aScanResult);
 
     WiFiNetwork mSavedNetwork   = {};