Skip to content

developing branch: gen_icon function name clash #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CJDumbleton opened this issue Feb 21, 2023 · 1 comment
Open

developing branch: gen_icon function name clash #22

CJDumbleton opened this issue Feb 21, 2023 · 1 comment

Comments

@CJDumbleton
Copy link

Re 'developing' branch: I made a mistake forgetting to rename the gen_icon(non_ir) function gen_non_ir_icon(non_ir) or similar. It clashes with the gen_icon(dev) function. Alternatively, you could combine gen_icon(dev) and gen_icon(non_ir) and pass in the type key as an argument. Do you want me to fix it and do another pull request?

@SiriosDev
Copy link
Owner

thank you very much, I am working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants