Merge pull request #1 from ThomasW-Skyline/1.0.0.X

SimonV-Skyline · web-flow · commit c009e50a7264 · 2024-11-28T17:16:07.000+01:00
update conversion to enum states
diff --git a/QAction_1/ProtocolExtensions.cs b/QAction_1/ProtocolExtensions.cs
diff --git a/QAction_1000/IfTable.cs b/QAction_1000/IfTable.cs
@@ -6,10 +6,10 @@
 
 	using Skyline.DataMiner.Scripting;
 	using Skyline.DataMiner.Utils.Interfaces;
+	using Skyline.DataMiner.Utils.Protocol.Extension;
 	using Skyline.DataMiner.Utils.Rates.Protocol;
 	using Skyline.DataMiner.Utils.SafeConverters;
 	using Skyline.DataMiner.Utils.SNMP;
-	using Skyline.Protocol.Extension;
 	using Skyline.Protocol.Interface;
 
 	public class IfTableTimeoutProcessor
@@ -285,8 +285,7 @@ public IfTableGetter(SLProtocol protocol)
 
 			public void Load()
 			{
-				IsSnmpAgentRestarted = Convert.ToBoolean(Convert.ToInt16(protocol.GetParameter(Parameter.iftablesnmpagentrestartflag)));
-
+				IsSnmpAgentRestarted = Convert.ToBoolean(protocol.GetParameter(Parameter.iftablesnmpagentrestartflag));
 				LoadIfTable();
 				LoadIfXTable();
 			}
diff --git a/QAction_1000/QAction_1000.csproj b/QAction_1000/QAction_1000.csproj
@@ -13,6 +13,7 @@
   <ItemGroup>
     <PackageReference Include="Skyline.DataMiner.Dev.Protocol" Version="10.2.0.25" />
     <PackageReference Include="Skyline.DataMiner.Utils.Interfaces" Version="1.0.0.3" />
+    <PackageReference Include="Skyline.DataMiner.Utils.Protocol.Extension" Version="1.0.0.3" />
     <PackageReference Include="Skyline.DataMiner.Utils.Rates.Protocol" Version="1.0.0.4" />
     <PackageReference Include="Skyline.DataMiner.Utils.SafeConverters" Version="1.0.0.1" />
   </ItemGroup>
diff --git a/QAction_1100/IfXTable.cs b/QAction_1100/IfXTable.cs
@@ -5,10 +5,10 @@
 
 	using Skyline.DataMiner.Scripting;
 	using Skyline.DataMiner.Utils.Interfaces;
+	using Skyline.DataMiner.Utils.Protocol.Extension;
 	using Skyline.DataMiner.Utils.Rates.Protocol;
 	using Skyline.DataMiner.Utils.SafeConverters;
 	using Skyline.DataMiner.Utils.SNMP;
-	using Skyline.Protocol.Extension;
 	using Skyline.Protocol.Interface;
 
 	public class IfxTableTimeoutProcessor
@@ -283,7 +283,7 @@ public IfXTableGetter(SLProtocol protocol)
 
 			public void Load()
 			{
-				IsSnmpAgentRestarted = Convert.ToBoolean(Convert.ToInt16(protocol.GetParameter(Parameter.ifxtablesnmpagentrestartflag)));
+				IsSnmpAgentRestarted = Convert.ToBoolean(protocol.GetParameter(Parameter.ifxtablesnmpagentrestartflag));
 
 				uint[] columnsToGet = new uint[]
 				{
@@ -333,7 +333,7 @@ public void SetColumns()
 
 			public void SetParams()
 			{
-				protocol.SetParams(SetParamsData);
+				protocol.SetParameters(SetParamsData);
 			}
 		}
 	}
diff --git a/QAction_1100/QAction_1100.csproj b/QAction_1100/QAction_1100.csproj
@@ -13,6 +13,7 @@
   <ItemGroup>
     <PackageReference Include="Skyline.DataMiner.Dev.Protocol" Version="10.2.0.25" />
     <PackageReference Include="Skyline.DataMiner.Utils.Interfaces" Version="1.0.0.3" />
+    <PackageReference Include="Skyline.DataMiner.Utils.Protocol.Extension" Version="1.0.0.3" />
     <PackageReference Include="Skyline.DataMiner.Utils.Rates.Protocol" Version="1.0.0.4" />
     <PackageReference Include="Skyline.DataMiner.Utils.SafeConverters" Version="1.0.0.1" />
   </ItemGroup>
diff --git a/QAction_1191/QAction_1191.cs b/QAction_1191/QAction_1191.cs
@@ -3,7 +3,7 @@
 using System.Linq;
 
 using Skyline.DataMiner.Scripting;
-using Skyline.Protocol.Extension;
+using Skyline.DataMiner.Utils.Protocol.Extension;
 
 using SLNetMessages = Skyline.DataMiner.Net.Messages;
 
diff --git a/QAction_1191/QAction_1191.csproj b/QAction_1191/QAction_1191.csproj
@@ -12,6 +12,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Skyline.DataMiner.Dev.Protocol" Version="10.2.0.25" />
+    <PackageReference Include="Skyline.DataMiner.Utils.Protocol.Extension" Version="1.0.0.3" />
   </ItemGroup>
   <ProjectExtensions>
     <VisualStudio>
diff --git a/QAction_1192/QAction_1192.csproj b/QAction_1192/QAction_1192.csproj
@@ -11,6 +11,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Skyline.DataMiner.Dev.Protocol" Version="10.2.0.25" />
+    <PackageReference Include="Skyline.DataMiner.Utils.Protocol.Extension" Version="1.0.0.3" />
     <PackageReference Include="Skyline.DataMiner.Utils.SNMP" Version="1.0.0.2" />
   </ItemGroup>
   <ProjectExtensions>
diff --git a/QAction_1257/QAction_1257.csproj b/QAction_1257/QAction_1257.csproj
@@ -11,6 +11,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Skyline.DataMiner.Dev.Protocol" Version="10.2.0.25" />
+    <PackageReference Include="Skyline.DataMiner.Utils.Protocol.Extension" Version="1.0.0.3" />
   </ItemGroup>
   <ProjectExtensions>
     <VisualStudio>
diff --git a/QAction_2/QAction_2.csproj b/QAction_2/QAction_2.csproj
@@ -11,6 +11,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="Skyline.DataMiner.Dev.Protocol" Version="10.2.0.25" />
+    <PackageReference Include="Skyline.DataMiner.Utils.Protocol.Extension" Version="1.0.0.3" />
     <PackageReference Include="Skyline.DataMiner.Utils.SNMP" Version="1.0.0.2" />
   </ItemGroup>
   <ProjectExtensions>
diff --git a/QAction_91/QAction_91.csproj b/QAction_91/QAction_91.csproj
diff --git a/QAction_Helper/QAction_Helper.cs b/QAction_Helper/QAction_Helper.cs
diff --git a/protocol.xml b/protocol.xml

Original file line number	Diff line number	Diff line change
`@@ -5,10 +5,10 @@`
`5`	`5`
`6`	`6`	`using Skyline.DataMiner.Scripting;`
`7`	`7`	`using Skyline.DataMiner.Utils.Interfaces;`
	`8`	`+ using Skyline.DataMiner.Utils.Protocol.Extension;`
`8`	`9`	`using Skyline.DataMiner.Utils.Rates.Protocol;`
`9`	`10`	`using Skyline.DataMiner.Utils.SafeConverters;`
`10`	`11`	`using Skyline.DataMiner.Utils.SNMP;`
`11`		`- using Skyline.Protocol.Extension;`
`12`	`12`	`using Skyline.Protocol.Interface;`
`13`	`13`
`14`	`14`	`public class IfxTableTimeoutProcessor`
`@@ -283,7 +283,7 @@ public IfXTableGetter(SLProtocol protocol)`
`283`	`283`
`284`	`284`	`public void Load()`
`285`	`285`	`{`
`286`		`- IsSnmpAgentRestarted = Convert.ToBoolean(Convert.ToInt16(protocol.GetParameter(Parameter.ifxtablesnmpagentrestartflag)));`
	`286`	`+ IsSnmpAgentRestarted = Convert.ToBoolean(protocol.GetParameter(Parameter.ifxtablesnmpagentrestartflag));`
`287`	`287`
`288`	`288`	`uint[] columnsToGet = new uint[]`
`289`	`289`	`{`
`@@ -333,7 +333,7 @@ public void SetColumns()`
`333`	`333`
`334`	`334`	`public void SetParams()`
`335`	`335`	`{`
`336`		`- protocol.SetParams(SetParamsData);`
	`336`	`+ protocol.SetParameters(SetParamsData);`
`337`	`337`	`}`
`338`	`338`	`}`
`339`	`339`	`}`