Dev/fixtopic filter bug (#22)

* Added topics from github guidelines SLC.

* Fixing the Topic Filtering bug.

Author: janstaelensskyline

CICD.Tools.GitHubToCatalogYamlTests/CatalogManagerTests.cs

@@ -178,6 +178,23 @@ public async Task ProcessCatalogYamlAsync_ShouldAddTagsFromRepository_WhenTagsAr
             mockFileSystem.Verify(fs => fs.File.WriteAllText(catalogFilePath, It.Is<string>(s => Regex.IsMatch(s, @"tags:\s*(?:-\s*\S+\s*)*-\s*newTag", RegexOptions.Multiline))), Times.Once);
         }
 
+        [TestMethod]
+        public async Task ProcessCatalogYamlAsync_ShouldFilterTagsThatMatchTypes()
+        {
+            // Arrange
+            var repoName = "SLC-AS-testRepo";
+            var yamlContent = "id: testId\nshort_description: test description";
+            mockFileSystem.Setup(fs => fs.File.Exists(catalogFilePath)).Returns(true); // catalog.yml exists
+            mockFileSystem.Setup(fs => fs.File.ReadAllText(catalogFilePath)).Returns(yamlContent);
+            mockGitHubService.Setup(s => s.GetRepositoryTopicsAsync()).ReturnsAsync(new List<string> { "dataminer-automation-script", "newTag","dataminer","otherTag", "dataminer-connector" });
+
+            // Act
+            await catalogManager.ProcessCatalogYamlAsync(repoName);
+
+            // Assert
+            mockFileSystem.Verify(fs => fs.File.WriteAllText(catalogFilePath, It.Is<string>(s => Regex.IsMatch(s, @"tags:\s*\n\s*-\s*newTag\s*\n\s*-\s*otherTag\s*(\n\s*#.*|\s*)*$", RegexOptions.Multiline))), Times.Once);
+        }
+
         [TestMethod]
         public async Task ProcessCatalogYamlAsync_ShouldUseRepositoryNameAsTitle_WhenTitleIsMissing()
         {

Skyline.DataMiner.CICD.Tools.GitHubToCatalogYaml/CatalogManager.cs

@@ -184,7 +184,7 @@ private async Task CheckTags(CatalogYaml catalogYaml)
                 catalogYaml.Tags = new List<string>();
             }
 
-            if(catalogYaml.Tags.Count >= 5)
+            if (catalogYaml.Tags.Count >= 5)
             {
                 logger.LogDebug("Catalog YAML has the max amount of tags already. Skipping the adding GitHub topics step.");
                 return;
@@ -245,17 +245,22 @@ private void CheckType(CatalogYaml catalogYaml, CleanTitle parsedRepoName)
             // Always check the tags
             if (catalogYaml.Tags != null)
             {
+                List<string> filteredTopics = new List<string>();
                 foreach (var topic in catalogYaml.Tags)
                 {
                     var inferredType = InferArtifactContentType(topic);
                     if (!String.IsNullOrWhiteSpace(inferredType))
                     {
                         catalogYaml.Type = inferredType;
-                        catalogYaml.Tags.Remove(topic);
                         logger.LogDebug($"Item Type could be inferred from repository topics {catalogYaml.Type}.");
-                        break;
+                    }
+                    else
+                    {
+                        filteredTopics.Add(topic);
                     }
                 }
+
+                catalogYaml.Tags = filteredTopics;
             }
 
             if (String.IsNullOrWhiteSpace(catalogYaml.Type))