Fixes Regression Tests to handle the introduced breaking changes.

Several types are no longer supported.

Author: janstaelensskyline

CICD.Tools.GitHubToCatalogYamlTests/CatalogManagerTests.cs

@@ -2,6 +2,7 @@
 {
     using System;
     using System.Collections.Generic;
+    using System.Text.RegularExpressions;
     using System.Threading.Tasks;
 
     using FluentAssertions;
@@ -174,7 +175,7 @@ public async Task ProcessCatalogYamlAsync_ShouldAddTagsFromRepository_WhenTagsAr
             await catalogManager.ProcessCatalogYamlAsync(repoName);
 
             // Assert
-            mockFileSystem.Verify(fs => fs.File.WriteAllText(catalogFilePath, It.Is<string>(s => s.Contains($"tags:{Environment.NewLine}  - newTag"))), Times.Once);
+            mockFileSystem.Verify(fs => fs.File.WriteAllText(catalogFilePath, It.Is<string>(s => Regex.IsMatch(s, @"tags:\s*(?:-\s*\S+\s*)*-\s*newTag", RegexOptions.Multiline))), Times.Once);
         }
 
         [TestMethod]
@@ -230,8 +231,8 @@ public async Task ProcessCatalogYamlAsync_ShouldUseExistingShortDescription_When
         [TestMethod]
         public async Task ProcessCatalogYamlAsync_ShouldInferTypeFromRepositoryName_WhenNoTypeIsDefined()
         {
-            // Arrange{ "DISMACRO", "dismacro" },
-            var repoName = "SLC-DISMACRO-testRepo";
+            // **SC**: `Scripted Connector`
+            var repoName = "SLC-SC-testRepo";
             var yamlContent = "id: testId\nshort_description: test description\ntags: [testTag]";
             mockFileSystem.Setup(fs => fs.File.Exists(catalogFilePath)).Returns(true); // catalog.yml exists
             mockFileSystem.Setup(fs => fs.File.ReadAllText(catalogFilePath)).Returns(yamlContent);
@@ -240,7 +241,7 @@ public async Task ProcessCatalogYamlAsync_ShouldInferTypeFromRepositoryName_When
             await catalogManager.ProcessCatalogYamlAsync(repoName);
 
             // Assert
-            mockFileSystem.Verify(fs => fs.File.WriteAllText(catalogFilePath, It.Is<string>(s => s.Contains("type: dismacro"))), Times.Once);
+            mockFileSystem.Verify(fs => fs.File.WriteAllText(catalogFilePath, It.Is<string>(s => s.Contains("type: Scripted Connector"))), Times.Once);
         }
 
         [TestMethod]
@@ -434,7 +435,7 @@ public async Task CheckType_ShouldInferTypeFromMultipleTopicsCorrectly()
             await catalogManager.ProcessCatalogYamlAsync(repoName);
 
             // Assert
-            mockFileSystem.Verify(fs => fs.File.WriteAllText(catalogFilePath, It.Is<string>(s => s.Contains("type: adhocdatasource"))), Times.Once);
+            mockFileSystem.Verify(fs => fs.File.WriteAllText(catalogFilePath, It.Is<string>(s => s.Contains("type: Ad Hoc Data Source"))), Times.Once);
         }
 
         [TestMethod]

CICD.Tools.GitHubToCatalogYamlTests/CleanTitleTests.cs

@@ -8,13 +8,13 @@
     public class CleanTitleTests
     {
         [TestMethod]
-        [DataRow("SkylineCommunications/SLC-AS-MediaOps-Apps", "MediaOps-Apps", "automationscript")]
-        [DataRow("SLC-AS-MediaOps-Apps", "MediaOps-Apps", "automationscript")]
-        [DataRow("SkylineCommunications/PCKTV-AS-RegressionTests", "RegressionTests", "automationscript")]
-        [DataRow("SkylineCommunications/RBM-AS-Playout", "Playout", "automationscript")]
-        [DataRow("SkylineCommunications/SLC-Doc-Vodafone-Deutschland-GmbH", "Vodafone-Deutschland-GmbH", "documentation")]
-        [DataRow("SkylineCommunications/FOXA-GQIDS-GetAppearTVData", "GetAppearTVData", "adhocdatasource")]
-        [DataRow("SkylineCommunications/YLE-C-Avid-iNewsOrder-Ingest", "Avid-iNewsOrder-Ingest", "connector")]
+        [DataRow("SkylineCommunications/SLC-AS-MediaOps-Apps", "MediaOps-Apps", "Automation")]
+        [DataRow("SLC-AS-MediaOps-Apps", "MediaOps-Apps", "Automation")]
+        [DataRow("SkylineCommunications/PCKTV-AS-RegressionTests", "RegressionTests", "Automation")]
+        [DataRow("SkylineCommunications/RBM-AS-Playout", "Playout", "Automation")]
+        [DataRow("SkylineCommunications/SLC-Doc-Vodafone-Deutschland-GmbH", "Vodafone-Deutschland-GmbH", "Custom Solution")]
+        [DataRow("SkylineCommunications/FOXA-GQIDS-GetAppearTVData", "GetAppearTVData", "Ad Hoc Data Source")]
+        [DataRow("SkylineCommunications/YLE-C-Avid-iNewsOrder-Ingest", "Avid-iNewsOrder-Ingest", "Connector")]
         [DataRow("SkylineCommunications/ngx-dwa-theme-creation-helper", "ngx-dwa-theme-creation-helper", null)]
         public void CleanTitleTestHappy(string input, string expectedTitle, string expectedType)
         {

Skyline.DataMiner.CICD.Tools.GitHubToCatalogYaml/CatalogYaml.cs

@@ -72,7 +72,7 @@ public class CatalogYaml
                                            "  - Standard Solution: If the Catalog item is a DataMiner Solution that is an out-of-the-box solution for a specific use case or application.\r\n" +
                                            "  - System Health: If the Catalog item is intended to monitor the health of a system.\r\n" +
                                            "  - User-Defined API: If the Catalog item is a DataMiner Automation script designed as a user-defined API.\r\n" +
-                                           "  - Visual Overview: If the Catalog item is a Microsoft Visio design.\r\n" +
+                                           "  - Visual Overview: If the Catalog item is a Microsoft Visio design.\r\n";
 
         /// <summary>
         /// Initializes a new instance of the <see cref="CatalogYaml"/> class.