Skip to content

Commit cd9fe94

Browse files
committed
update
1 parent 2295354 commit cd9fe94

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

Protocol/Error Messages/Protocol/Params/Param/Display/Decimals/CheckDecimalsTag.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ public static IValidationResult InvalidTagForDateTime(IValidate test, IReadable
2828
GroupDescription = "",
2929
Description = String.Format("Missing tag '{0}' with expected value '{1}' for {2} '{3}'.", "Display/Decimals", "8", "Param", paramId),
3030
HowToFix = "Add a Protocol/Params/Param/Display/Decimals tag with value 8.",
31-
ExampleCode = "<Display>" + Environment.NewLine + " <RTDisplay>true</RTDisplay>" + Environment.NewLine + " <Decimals>8</Decimals>" + Environment.NewLine + "</Display>" + Environment.NewLine + "<Measurement>" + Environment.NewLine + " <Type options=\"datetime\">number</Type>" + Environment.NewLine + "</Measurement>" + Environment.NewLine + "",
32-
Details = "By default, only 6 decimals are saved in memory. Parameters holding datetime values need at least 8 decimals to be accurate.Otherwise, there might be rounding issues when retrieving the parameter from an external source like an Automation script.",
31+
ExampleCode = "<Display>" + Environment.NewLine + " <RTDisplay>true</RTDisplay>" + Environment.NewLine + " <Decimals>8</Decimals>" + Environment.NewLine + "</Display>" + Environment.NewLine + "<Measurement>" + Environment.NewLine + " <Type options=\"datetime\">number</Type>" + Environment.NewLine + "</Measurement>",
32+
Details = "By default, only 6 decimals are saved in memory. Parameters holding datetime values need at least 8 decimals to be accurate." + Environment.NewLine + "Otherwise, there might be rounding issues when retrieving the parameter from an external source like an Automation script.",
3333
HasCodeFix = false,
3434

3535
PositionNode = positionNode,

Protocol/Tests/Protocol/Params/Param/Display/Decimals/CheckDecimalsTag.cs

+4-6
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,14 @@ namespace Skyline.DataMiner.CICD.Validators.Protocol.Tests.Protocol.Params.Param
22
{
33
using System;
44
using System.Collections.Generic;
5-
5+
6+
using Skyline.DataMiner.CICD.Models.Protocol.Read;
67
using Skyline.DataMiner.CICD.Validators.Common.Interfaces;
78
using Skyline.DataMiner.CICD.Validators.Common.Model;
89
using Skyline.DataMiner.CICD.Validators.Protocol.Common;
910
using Skyline.DataMiner.CICD.Validators.Protocol.Common.Attributes;
1011
using Skyline.DataMiner.CICD.Validators.Protocol.Common.Extensions;
1112
using Skyline.DataMiner.CICD.Validators.Protocol.Interfaces;
12-
using Skyline.DataMiner.CICD.Models.Protocol.Read;
13-
1413

1514
[Test(CheckId.CheckDecimalsTag, Category.Param)]
1615
internal class CheckDecimalsTag : IValidate/*, ICodeFix, ICompare*/
@@ -46,7 +45,6 @@ public List<IValidationResult> Validate(ValidatorContext context)
4645
return results;
4746
}
4847

49-
/*
5048
public ICodeFixResult Fix(CodeFixContext context)
5149
{
5250
CodeFixResult result = new CodeFixResult();
@@ -61,12 +59,12 @@ public ICodeFixResult Fix(CodeFixContext context)
6159

6260
return result;
6361
}
64-
62+
6563
public List<IValidationResult> Compare(MajorChangeCheckContext context)
6664
{
6765
List<IValidationResult> results = new List<IValidationResult>();
6866

6967
return results;
70-
}*/
68+
}
7169
}
7270
}

0 commit comments

Comments
 (0)