Specify some things in props that are needed to reduce warnings and should be default anyway for DM projects (can be removed from the Directory.Build.props file in DIS)

MichielOda · MichielOda · commit 950c44d9cfbf · 2024-11-29T09:28:13.000+01:00
diff --git a/Sdk/Sdk/Sdk.props b/Sdk/Sdk/Sdk.props
@@ -1,3 +1,9 @@
 ﻿<Project>
     <Import Project="Sdk.props" Sdk="Microsoft.NET.Sdk" Condition=" '$(MicrosoftCommonPropsHasBeenImported)' != 'true' "/>
+
+    <PropertyGroup>
+        <PlatformTarget>x86</PlatformTarget>
+        <DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
+        <DefineConstants>$(DefineConstants);DCFv1;DBInfo;ALARM_SQUASHING</DefineConstants>
+    </PropertyGroup>
 </Project>
diff --git a/Sdk/Tasks/DmappCreation.cs b/Sdk/Tasks/DmappCreation.cs
@@ -20,7 +20,7 @@ namespace Skyline.DataMiner.Sdk
 
     public class DmappCreation : Task, ICancelableTask
     {
-        private bool cancel = false;
+        private bool cancel;
 
         public string ProjectFile { get; set; }
         public string ProjectType { get; set; }

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ namespace Skyline.DataMiner.Sdk`
`20`	`20`
`21`	`21`	`public class DmappCreation : Task, ICancelableTask`
`22`	`22`	`{`
`23`		`- private bool cancel = false;`
	`23`	`+ private bool cancel;`
`24`	`24`
`25`	`25`	`public string ProjectFile { get; set; }`
`26`	`26`	`public string ProjectType { get; set; }`