Skip to content

Commit e38d061

Browse files
committed
Final small tweaks
1 parent d55847e commit e38d061

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

Sdk/Tasks/DmappCreation.cs

+1-6
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ namespace Skyline.DataMiner.Sdk.Tasks
55
using System.Collections.Generic;
66
using System.Diagnostics;
77
using System.Linq;
8-
using System.Security.Cryptography;
9-
using System.Text;
108
using System.Text.RegularExpressions;
119

1210
using Microsoft.Build.Framework;
@@ -294,7 +292,7 @@ private bool TryCreateAppPackageBuilder(PackageCreationData preparedData, DataMi
294292
return true;
295293
}
296294

297-
public static string CleanDmappVersion(string version)
295+
private static string CleanDmappVersion(string version)
298296
{
299297
// Check if version matches a.b.c
300298
if (Regex.IsMatch(version, @"^\d+\.\d+\.\d+$"))
@@ -380,9 +378,6 @@ private PackageCreationData PrepareDataForProject(Project project, PackageCreati
380378
Project = project,
381379
LinkedProjects = referencedProjects,
382380
TemporaryDirectory = preparedData.TemporaryDirectory,
383-
384-
// TODO?: Readout version from new project? Possibility for users to indicate nothing changed to the script (in the about), BUT can easily be forgotten to be updated.
385-
// Same for MinimumRequiredDmVersion (could be useful to throw warning/error when higher than the package itself)
386381
MinimumRequiredDmVersion = preparedData.MinimumRequiredDmVersion,
387382
Version = preparedData.Version,
388383
};

0 commit comments

Comments
 (0)