Skip to content

Commit 9091978

Browse files
SysixSysix
authored
Merge pull request #140 from Sysix/small-improvments
fix deprecated tests + add strict type cs rule
2 parents 0a7c052 + 7f94b3f commit 9091978

9 files changed

+14
-11
lines changed

‎.php-cs-fixer.dist.php

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
->setRiskyAllowed(true)
1111
->setRules([
1212
'@PSR12' => true,
13+
'declare_strict_types' => true,
1314
'modernize_types_casting' => true,
1415
'multiline_comment_opening_closing' => true,
1516
'multiline_whitespace_before_semicolons' => true,

‎src/Utils.php

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
declare(strict_types=1);
4+
35
namespace Sysix\LexOffice;
46

57
use GuzzleHttp\Psr7\MultipartStream;

‎tests/Clients/CreditNoteTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public function testGetPage(): void
107107

108108
$this->assertEquals('GET', $api->getRequest()->getMethod());
109109
$this->assertEquals(
110-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=creditnote&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
110+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=creditnote&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
111111
$api->getRequest()->getUri()->__toString()
112112
);
113113
}
@@ -127,7 +127,7 @@ public function testGetAll(): void
127127

128128
$this->assertEquals('GET', $api->getRequest()->getMethod());
129129
$this->assertEquals(
130-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=creditnote&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
130+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=creditnote&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
131131
$api->getRequest()->getUri()->__toString()
132132
);
133133
}

‎tests/Clients/DeliveryNoteTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function testGetPage(): void
7373

7474
$this->assertEquals('GET', $api->getRequest()->getMethod());
7575
$this->assertEquals(
76-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=deliverynote&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
76+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=deliverynote&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
7777
$api->getRequest()->getUri()->__toString()
7878
);
7979
}
@@ -93,7 +93,7 @@ public function testGetAll(): void
9393

9494
$this->assertEquals('GET', $api->getRequest()->getMethod());
9595
$this->assertEquals(
96-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=deliverynote&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
96+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=deliverynote&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
9797
$api->getRequest()->getUri()->__toString()
9898
);
9999
}

‎tests/Clients/DownPaymentInvoiceTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function testGetAll(): void
4242

4343
$this->assertEquals('GET', $api->getRequest()->getMethod());
4444
$this->assertEquals(
45-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=downpaymentinvoice&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
45+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=downpaymentinvoice&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
4646
$api->getRequest()->getUri()->__toString()
4747
);
4848
}

‎tests/Clients/InvoiceTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public function testPage(): void
107107

108108
$this->assertEquals('GET', $api->getRequest()->getMethod());
109109
$this->assertEquals(
110-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=invoice&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
110+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=invoice&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
111111
$api->getRequest()->getUri()->__toString()
112112
);
113113
}
@@ -127,7 +127,7 @@ public function testGetAll(): void
127127

128128
$this->assertEquals('GET', $api->getRequest()->getMethod());
129129
$this->assertEquals(
130-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=invoice&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
130+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=invoice&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
131131
$api->getRequest()->getUri()->__toString()
132132
);
133133
}

‎tests/Clients/OrderConfirmationTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function testGetPage(): void
7373

7474
$this->assertEquals('GET', $api->getRequest()->getMethod());
7575
$this->assertEquals(
76-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=orderconfirmation&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
76+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=orderconfirmation&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
7777
$api->getRequest()->getUri()->__toString()
7878
);
7979
}
@@ -93,7 +93,7 @@ public function testGetAll(): void
9393

9494
$this->assertEquals('GET', $api->getRequest()->getMethod());
9595
$this->assertEquals(
96-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=orderconfirmation&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
96+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=orderconfirmation&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
9797
$api->getRequest()->getUri()->__toString()
9898
);
9999
}

‎tests/Clients/QuotationTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public function testGetAll(): void
7676

7777
$this->assertEquals('GET', $api->getRequest()->getMethod());
7878
$this->assertEquals(
79-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=quotation&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100',
79+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=quotation&voucherStatus=draft%2Copen%2Cpaid%2Cpaidoff%2Cvoided%2Caccepted%2Crejected&size=100&sort=voucherNumber%2CDESC',
8080
$api->getRequest()->getUri()->__toString()
8181
);
8282
}

‎tests/Clients/VoucherTest.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ public function testGetAll(): void
150150

151151
$this->assertEquals('GET', $api->getRequest()->getMethod());
152152
$this->assertEquals(
153-
$api->apiUrl . '/v1/voucherlist?page=0&sort=voucherNumber%2CDESC&voucherType=salesinvoice%2Csalescreditnote%2Cpurchaseinvoice%2Cpurchasecreditnote&voucherStatus=open%2Cpaid%2Cpaidoff%2Cvoided%2Ctransferred%2Csepadebit&size=100',
153+
$api->apiUrl . '/v1/voucherlist?page=0&voucherType=salesinvoice%2Csalescreditnote%2Cpurchaseinvoice%2Cpurchasecreditnote&voucherStatus=open%2Cpaid%2Cpaidoff%2Cvoided%2Ctransferred%2Csepadebit&size=100&sort=voucherNumber%2CDESC',
154154
$api->getRequest()->getUri()->__toString()
155155
);
156156
}

0 commit comments

Comments
 (0)