Merge pull request #30 from clicksports/bugfix/cache-with-query

fix cache with query

Author: Sysix

src/Traits/CacheResponseTrait.php

@@ -35,7 +35,7 @@ public function setCacheInterface(CacheItemPoolInterface $cache): self
      */
     protected function getCacheName(RequestInterface $request): string
     {
-        return 'lex-office-' . str_replace('/', '-', $request->getUri()->getPath());
+        return 'lex-office-' . str_replace('/', '-', $request->getUri()->getPath()) . $request->getUri()->getQuery();
     }
 
 

tests/CacheResponseTraitTest.php

@@ -124,6 +124,32 @@ public function testSetCacheResponse($stub)
         // test on delete
         $stub->setCacheResponse(new Request('DELETE', '/'), $fakeResponse);
         $this->assertNull($cacheInterface->getItem($cacheKey)->get());
+
+        $cacheInterface->deleteItem($cacheKey);
+    }
+
+    /**
+     * @depends testSetCacheInterface
+     */
+    public function testDifferentParamsCache($stub)
+    {
+        $stub->newRequest('GET', '/?a');
+        $fakeResponse = new Response(200, [], 'fake');
+        $stub->setCacheResponse($stub->request, $fakeResponse);
+
+        $this->assertEquals(
+            $this->transformToString($stub->getCacheResponse($stub->request)),
+            $this->transformToString($fakeResponse)
+        );
+
+        $stub->newRequest('GET', '/?b');
+        $fakeResponse = new Response(200, [], 'fake2');
+        $stub->setCacheResponse($stub->request, $fakeResponse);
+
+        $this->assertEquals(
+            $this->transformToString($stub->getCacheResponse($stub->request)),
+            $this->transformToString($fakeResponse)
+        );
     }
 
     protected function transformToString(ResponseInterface $response)