Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service naming doesn't allow simplified playbook reference #62

Open
Nuttymoon opened this issue Jul 29, 2022 · 2 comments
Open

Service naming doesn't allow simplified playbook reference #62

Nuttymoon opened this issue Jul 29, 2022 · 2 comments

Comments

@Nuttymoon
Copy link
Member

Nuttymoon commented Jul 29, 2022

For livy-spark3 and zookeeper-kafka services, the playbooks should be accessible as follow:

- name: Deploy Livy for Spark 3
  import_playbook: tosit.tdp_extra.meta.livy-spark3

This ends up with the error:

Could not find or access '.../playbooks/tdp/deploy/tosit.tdp_extra.meta.livy-spark3' on the Ansible Controller.

Whereas this work for:

- name: Deploy Livy
  import_playbook: tosit.tdp_extra.meta.livy

This is probably due to the - in the playbook name. All playbooks for livy-spark3 and zookeeper-kafka are impacted.

@gboutry how do you suggest we solve the issue to make playbooks names compatible with Ansible resolver? Because meta playbooks are generated by tdp-lib, we probably have to change the rules for playbooks naming (e.g. changing - to _).

@gboutry
Copy link
Member

gboutry commented Jul 29, 2022

Does it work in cases like tosit.tdp.meta.zookeeper ?

@Nuttymoon
Copy link
Member Author

Nuttymoon commented Jul 29, 2022

Does it work in cases like tosit.tdp.meta.zookeeper ?

Yes this notebook works:

- name: Deploy ZooKeeper
  import_playbook: tosit.tdp.meta.zookeeper

And I tried changing - to _ and it's starts working:

- name: Deploy Livy
  import_playbook: tosit.tdp_extra.meta.livy_spark3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants