Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please extract this to a function, probably inside mainactivityhelper class #4322

Closed
Birthzero84 opened this issue Jan 1, 2025 · 3 comments
Closed

please extract this to a function, probably inside mainactivityhelper class #4322

Birthzero84 opened this issue Jan 1, 2025 · 3 comments
Labels
Issue-Discussion Deprecated: use discussions tab. Needs-OPResponse Needs original poster to respond

Comments

@Birthzero84
Copy link 

          please extract this to a function, probably inside mainactivityhelper class

Originally posted by @VishnuSanal in #4290 (comment)
@VishnuSanal
Copy link
Member

This was outdated, IIRC. @yashwanthgajji please confirm. 🤔

@VishnuSanal VishnuSanal added Issue-Discussion Deprecated: use discussions tab. Needs-OPResponse Needs original poster to respond labels Jan 1, 2025
@yashwanthgajji
Copy link

Hi @Birthzero84 ,

That comment was outdated. I have changed the code and didn't duplicated the code. File "ItemPopupMenu.java" has no changes in the latest commit. Please check the files changed in the latest commit and let me know if there is any duplicate code. I will extract it into a function.

Thank you.

@VishnuSanal
Copy link
Member

Please check the files changed in the latest commit and let me know if there is any duplicate code. I will extract it into a function.

no, it's good. :)

@VishnuSanal VishnuSanal reopened this Jan 2, 2025
@VishnuSanal VishnuSanal closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Discussion Deprecated: use discussions tab. Needs-OPResponse Needs original poster to respond
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yashwanthgajji @VishnuSanal @Birthzero84