Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split AuthnService into login and authentication service #276

Open
byewokko opened this issue Sep 19, 2023 · 0 comments
Open

Split AuthnService into login and authentication service #276

byewokko opened this issue Sep 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@byewokko
Copy link
Collaborator

  • The code is massive and confusing and combines different responsibilities.
  • AuthenticationService resolves different means of authentication: username+password, api key, access token, cookie etc.
  • LoginService manages the login flow, login sessions, login descriptors. It uses Authentication service for evaluating the passwords and other authentication factors.
@byewokko byewokko added the enhancement New feature or request label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@byewokko