(maint) Update Pester test for Pester v5 norms

Pester v5 introduced the BeforeDiscovery block, and any module that is
loaded in this context is not loaded when tests actually run. By default
anything outside of any other block run at this time, but to be
explicit, we should put them in a BeforeDiscovery block. This commit
removes the unneeded Import-Module statements from files we're editting
for the PR, as well as moves any variable assignments into
BeforeDiscovery so they're available and explicit.

Author: corbob

tests/chocolatey-tests/commands/choco-info.Tests.ps1

@@ -1,5 +1,3 @@
-Import-Module helpers/common-helpers
-
 Describe "choco info" -Tag Chocolatey, InfoCommand {
     BeforeDiscovery {
         $licensedProxyFixed = Test-PackageIsEqualOrHigher 'chocolatey.extension' 2.2.0-beta -AllowMissingPackage

tests/chocolatey-tests/commands/choco-install.Tests.ps1

@@ -1,7 +1,3 @@
-Import-Module helpers/common-helpers
-
-# https://github.com/chocolatey/choco/blob/master/src/chocolatey.tests.integration/scenarios/InstallScenarios.cs
-
 Describe "choco install" -Tag Chocolatey, InstallCommand {
     BeforeDiscovery {
         $isLicensed30OrMissingVersion = Test-PackageIsEqualOrHigher 'chocolatey.extension' '3.0.0-beta' -AllowMissingPackage

tests/chocolatey-tests/commands/choco-pack.Tests.ps1

@@ -1,8 +1,9 @@
-Import-Module helpers/common-helpers
 
-$successPack = @('basic'; 'basic-dependencies'; "cdata"; "full")
-# Required elements, that can also not be empty
-$missingFailures = @('id'; 'version'; 'authors'; 'description')
+Describe "choco pack" -Tag Chocolatey, PackCommand {
+    BeforeDiscovery {
+        $successPack = @('basic'; 'basic-dependencies'; "cdata"; "full")
+        # Required elements, that can also not be empty
+        $missingFailures = @('id'; 'version'; 'authors'; 'description')
 # Elements that can not be set to an empty string, but are not required
 $emptyFailures = @(
     "projectUrl"
@@ -24,11 +25,11 @@ $invalidFailures = @(
     @{id = 'licenseUrl'; message = "ERROR: CHCU0001: 'invalid license url' is not a valid URL for the licenseUrl element in the package nuspec file." }
     @{id = "version"; message = "ERROR: CHCU0001: 'INVALID' is not a valid version string in the package nuspec file." }
     @{id = "no-content"; message = "Cannot create a package that has no dependencies nor content." } # This is a message from NuGet.Client, we may want to take ownership of it eventually.
-    @{id = "id"; message = "The package ID 'invalid id' contains invalid characters. Examples of valid package IDs include 'MyPackage' and 'MyPackage.Sample'." } # This is a message from NuGet.Client, we may want to take ownership of it eventually.
-    @{id = "requirelicenseacceptance"; message = "ERROR: CHCR0002: Enabling license acceptance requires a license url." }
-)
+            @{id = "id"; message = "The package ID 'invalid id' contains invalid characters. Examples of valid package IDs include 'MyPackage' and 'MyPackage.Sample'." } # This is a message from NuGet.Client, we may want to take ownership of it eventually.
+            @{id = "requirelicenseacceptance"; message = "ERROR: CHCR0002: Enabling license acceptance requires a license url." }
+        )
+    }
 
-Describe "choco pack" -Tag Chocolatey, PackCommand {
     BeforeAll {
         Remove-NuGetPaths
         $testPackageLocation = "$(Get-TempDirectory)ChocolateyTests\packages"

tests/chocolatey-tests/commands/choco-uninstall.Tests.ps1

@@ -1,5 +1,3 @@
-Import-Module helpers/common-helpers
-
 Describe "choco uninstall" -Tag Chocolatey, UninstallCommand {
     BeforeAll {
         Remove-NuGetPaths

tests/chocolatey-tests/commands/choco-upgrade.Tests.ps1

@@ -1,5 +1,3 @@
-Import-Module helpers/common-helpers
-
 Describe "choco upgrade" -Tag Chocolatey, UpgradeCommand {
     BeforeAll {
         Remove-NuGetPaths