Skip to content

Commit 4efe777

Browse files
andy31415andreilitvinrestyled-commitsbzbarsky-applejmartinez-silabs
authoredOct 31, 2024
Enforce DataModel::Provider everywhere (project-chip#36319)
* Pass 1: remove a large set of ifdefs * More flags removes * Remove more flags * More flags removes * Clean up a few more builders * Clean up references from ember compatibility functions and make the data model implementation of reporting and attribute path expand iterator be the only implemented versions * Remove ServerClusterCommandExists * Remove ConcreteAttributePathExists * Remove ReadSingleClusterData * Remove GetAttributeMetadata * Even more cleanup * Remove invalid include * Update target test file: we removed all DM enable/disable * Add back endif * Cleanup targets for building * Cleanup unused target * one more unused function removal * Fix up one condition * Restyled by clang-format * Update src/app/AttributePathExpandIterator.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/AttributePathExpandIterator.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/darwin/Framework/CHIP/ServerEndpoint/MTRServerAccessControl.mm Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Add back missed code * Restyled by clang-format * Update src/app/tests/BUILD.gn Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com> --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>
1 parent e5ae065 commit 4efe777

File tree

67 files changed

+197
-3148
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+197
-3148
lines changed
 

‎.github/workflows/build.yaml

+6-6
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ jobs:
7676
with:
7777
languages: "cpp"
7878
- name: Setup Build
79-
run: scripts/build/gn_gen.sh --args="chip_config_memory_debug_checks=true chip_config_memory_debug_dmalloc=false chip_data_model_check_die_on_failure=true"
79+
run: scripts/build/gn_gen.sh --args="chip_config_memory_debug_checks=true chip_config_memory_debug_dmalloc=false"
8080
- name: Run Build
8181
run: scripts/run_in_build_env.sh "ninja -C ./out"
8282
- name: Run Tests
@@ -183,7 +183,7 @@ jobs:
183183
scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
184184
- name: Setup Build, Run Build and Run Tests
185185
run: |
186-
BUILD_TYPE=gcc_release scripts/build/gn_gen.sh --args="is_debug=false chip_data_model_check_die_on_failure=true"
186+
BUILD_TYPE=gcc_release scripts/build/gn_gen.sh --args="is_debug=false"
187187
scripts/run_in_build_env.sh "ninja -C ./out/gcc_release"
188188
BUILD_TYPE=gcc_release scripts/tests/gn_tests.sh
189189
- name: Clean output
@@ -205,14 +205,14 @@ jobs:
205205
esac
206206
207207
rm -rf ./out/sanitizers
208-
BUILD_TYPE=sanitizers scripts/build/gn_gen.sh --args="$GN_ARGS chip_data_model_check_die_on_failure=true" --export-compile-commands
208+
BUILD_TYPE=sanitizers scripts/build/gn_gen.sh --args="$GN_ARGS" --export-compile-commands
209209
BUILD_TYPE=sanitizers scripts/tests/gn_tests.sh
210210
done
211211
- name: Generate tests with sanitizers (for tidy)
212212
if: github.event.pull_request.number != null
213213
run: |
214214
rm -rf ./out/sanitizers
215-
BUILD_TYPE=sanitizers scripts/build/gn_gen.sh --args="is_clang=true is_asan=true chip_data_model_check_die_on_failure=true" --export-compile-commands
215+
BUILD_TYPE=sanitizers scripts/build/gn_gen.sh --args="is_clang=true is_asan=true" --export-compile-commands
216216
- name: Ensure codegen is done for sanitize
217217
run: |
218218
./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/sanitizers"
@@ -333,7 +333,7 @@ jobs:
333333

334334
- name: Setup Build, Run Build and Run Tests
335335
run: |
336-
scripts/build/gn_gen.sh --args="enable_rtti=true chip_config_memory_debug_checks=false chip_config_memory_debug_dmalloc=false chip_generate_link_map_file=false chip_data_model_check_die_on_failure=true"
336+
scripts/build/gn_gen.sh --args="enable_rtti=true chip_config_memory_debug_checks=false chip_config_memory_debug_dmalloc=false chip_generate_link_map_file=false"
337337
scripts/run_in_build_env.sh "ninja -C ./out"
338338
scripts/tests/gn_tests.sh
339339
- name: Setup test python environment
@@ -439,7 +439,7 @@ jobs:
439439
# We want to build various standalone example apps (similar to what examples-linux-standalone.yaml
440440
# does), so use target_os="all" to get those picked up as part of the "unified" build. But then
441441
# to save CI resources we want to exclude the "host clang" build, which uses the pigweed clang.
442-
scripts/build/gn_gen.sh --args='target_os="all" is_asan=true enable_host_clang_build=false chip_data_model_check_die_on_failure=true' --export-compile-commands
442+
scripts/build/gn_gen.sh --args='target_os="all" is_asan=true enable_host_clang_build=false' --export-compile-commands
443443
scripts/run_in_build_env.sh "ninja -C ./out/$BUILD_TYPE"
444444
scripts/tests/gn_tests.sh
445445
- name: Ensure codegen is done for default

‎.github/workflows/examples-linux-arm.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
--target linux-arm64-chip-tool-nodeps-ipv6only \
6666
--target linux-arm64-lock-clang \
6767
--target linux-arm64-minmdns-clang \
68-
--target linux-arm64-light-data-model-enabled-rpc-ipv6only-clang \
68+
--target linux-arm64-light-rpc-ipv6only-clang \
6969
--target linux-arm64-thermostat-no-ble-clang \
7070
--target linux-arm64-lit-icd-no-ble-clang \
7171
--target linux-arm64-fabric-admin-clang-rpc \

0 commit comments

Comments
 (0)
Please sign in to comment.