From 5181e0c9a50031f8349699cb6932cac286369b3b Mon Sep 17 00:00:00 2001 From: MunifTanjim Date: Tue, 4 Dec 2018 14:19:30 +0600 Subject: [PATCH 1/2] fix template/parseEnvironment function fixes #573 --- config/template/template.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/template/template.go b/config/template/template.go index bad15d9b..30894f0e 100644 --- a/config/template/template.go +++ b/config/template/template.go @@ -54,7 +54,7 @@ func parseEnvironment(environ []string) Environment { return env } for _, e := range environ { - kv := strings.Split(e, "=") + kv := strings.SplitN(e, "=", 2) env[kv[0]] = kv[1] } return env From 71c100da2803d0eaba33a56a1e55211a2dd00df0 Mon Sep 17 00:00:00 2001 From: MunifTanjim Date: Fri, 3 May 2019 21:09:09 +0600 Subject: [PATCH 2/2] add test case for template/parseEnvironment fn --- config/template/template_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config/template/template_test.go b/config/template/template_test.go index 0b7ee982..ed7a13e9 100644 --- a/config/template/template_test.go +++ b/config/template/template_test.go @@ -14,10 +14,12 @@ func TestParseEnvironment(t *testing.T) { parsed = parseEnvironment([]string{ "VAR1=test", "VAR2=test2", + "VAR3=test3=w/equals==", }) assert.Equal(t, Environment{ "VAR1": "test", "VAR2": "test2", + "VAR3": "test3=w/equals==", }, parsed) }