fix: specify import exception type and add typing-extensions to deps (#212)

* fix: specify import exception type

* fix: specify import error

* test: cancel duplicate runs

* fix: use different concurrency key

* fix: need typing extensions on lower pythons

* fix: need typing extensions

* fix: try this concurrency

* fix: try this concurrency

Author: beckermr

.github/workflows/main.yml

@@ -5,10 +5,6 @@ on:
   pull_request:
     branches: [main, devel]
 
-concurrency:
-  group: ${{ github.workflow }}-${{ github.ref }}
-  cancel-in-progress: true
-
 jobs:
   run-if-changes:
     runs-on: ubuntu-latest
@@ -132,6 +128,9 @@ jobs:
         matplotlib-version: ${{ fromJson(needs.get-versions.outputs.matplotlib-versions) }}
       fail-fast: false
     uses: ./.github/workflows/build-ultraplot.yml
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.python-version }}-${{ matrix.matplotlib-version }}
+      cancel-in-progress: true
     with:
       python-version: ${{ matrix.python-version }}
       matplotlib-version: ${{ matrix.matplotlib-version }}

environment.yml

@@ -22,6 +22,7 @@ dependencies:
   - sphinx-autoapi
   - sphinx-automodapi
   - sphinx-rtd-theme
+  - typing-extensions
   - basemap >=1.4.1
   - pre-commit
   - sphinx-design

pyproject.toml

@@ -33,7 +33,8 @@ classifiers = [
 ]
 dependencies= [
     "numpy>=1.26.0",
-    "matplotlib>=3.9,<3.10"  # bump to 3.11 when basemap is updated
+    "matplotlib>=3.9,<3.10",  # bump to 3.11 when basemap is updated
+    "typing-extensions; python_version < '3.12'",
 ]
 dynamic = ["version"]
 

ultraplot/axes/geo.py

@@ -9,7 +9,7 @@
 try:
     # From python 3.12
     from typing import override
-except:
+except ImportError:
     # From Python 3.5
     from typing_extensions import override
 

ultraplot/figure.py

@@ -9,7 +9,7 @@
 
 try:
     from typing import List
-except:
+except ImportError:
     from typing_extensions import List
 
 import matplotlib.axes as maxes