Code quality

Author: florianbecker

source/Logger_any.h

@@ -66,7 +66,7 @@ namespace vx::logger {
 
     return {
 
-      std::type_index( typeid( T ) ),
+      std::type_index( static_cast<std::type_index>( typeid( T ) ) ),
       [ function = _function ]( Logger &_logger,
                                 [[maybe_unused]] const std::any &_any ) {
         function( _logger, std::any_cast<const T &>( _any ) );

source/Serial.cpp

@@ -30,12 +30,13 @@
 
 /* c header */
 #include <cerrno>
+#include <cstddef> // std::size_t
 #include <cstdint> // std::int32_t
 #include <cstdio>
 #include <cstring> // strerror_r
 
 /* system header */
-#include <fcntl.h> // open
+#include <sys/fcntl.h> // open
 #include <termios.h>
 #include <unistd.h> // write, read, close
 
@@ -129,13 +130,16 @@ namespace vx {
     }
   }
 
-  /**
-   * @brief Return timestamp in milliseconds.
-   * @return Timestamp in milliseconds.
-   */
-  static inline std::chrono::milliseconds timestampMs() noexcept {
+  namespace {
 
-    return std::chrono::duration_cast<std::chrono::milliseconds>( std::chrono::steady_clock::now().time_since_epoch() );
+    /**
+     * @brief Return timestamp in milliseconds.
+     * @return Timestamp in milliseconds.
+     */
+    inline std::chrono::milliseconds timestampMs() noexcept {
+
+      return std::chrono::duration_cast<std::chrono::milliseconds>( std::chrono::steady_clock::now().time_since_epoch() );
+    }
   }
 
   bool Serial::flush() const {

source/StringUtils_apple.cpp

@@ -28,6 +28,9 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+/* c header */
+#include <cstddef>
+
 /* stl header */
 #include <string>