Skip to content

Commit 9b78310

Browse files
chore: fix tests
1 parent 89f3de4 commit 9b78310

File tree

4 files changed

+58
-15
lines changed

4 files changed

+58
-15
lines changed

server/src/controllers/__tests__/client.controller.test.ts

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,10 @@ describe('Client controller', () => {
130130
},
131131
threadOf: {
132132
populate: {
133-
authorUser: true
133+
authorUser: {
134+
populate: true,
135+
avatar: { populate: true },
136+
},
134137
}
135138
}
136139
}
@@ -179,7 +182,10 @@ describe('Client controller', () => {
179182
},
180183
threadOf: {
181184
populate: {
182-
authorUser: true
185+
authorUser: {
186+
populate: true,
187+
avatar: { populate: true },
188+
},
183189
}
184190
}
185191
}
@@ -222,7 +228,10 @@ describe('Client controller', () => {
222228
},
223229
threadOf: {
224230
populate: {
225-
authorUser: true
231+
authorUser: {
232+
populate: true,
233+
avatar: { populate: true },
234+
},
226235
}
227236
}
228237
}
@@ -259,7 +268,10 @@ describe('Client controller', () => {
259268
},
260269
threadOf: {
261270
populate: {
262-
authorUser: true
271+
authorUser: {
272+
populate: true,
273+
avatar: { populate: true },
274+
},
263275
}
264276
}
265277
}

server/src/controllers/__tests__/utils/parser.test.ts

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,12 @@ describe('Parser', () => {
2020
},
2121
threadOf: {
2222
populate: {
23-
authorUser: true,
23+
authorUser: {
24+
populate: true,
25+
avatar: {
26+
populate: true,
27+
}
28+
},
2429
},
2530
},
2631
},
@@ -77,7 +82,10 @@ describe('Parser', () => {
7782
},
7883
threadOf: {
7984
populate: {
80-
authorUser: true,
85+
authorUser: {
86+
populate: true,
87+
avatar: { populate: true },
88+
},
8189
},
8290
},
8391
},
@@ -134,7 +142,10 @@ describe('Parser', () => {
134142
},
135143
threadOf: {
136144
populate: {
137-
authorUser: true,
145+
authorUser: {
146+
populate: true,
147+
avatar: { populate: true },
148+
},
138149
},
139150
},
140151
},
@@ -203,7 +214,10 @@ describe('Parser', () => {
203214
},
204215
threadOf: {
205216
populate: {
206-
authorUser: true,
217+
authorUser: {
218+
populate: true,
219+
avatar: { populate: true },
220+
},
207221
},
208222
},
209223
},
@@ -242,7 +256,10 @@ describe('Parser', () => {
242256
},
243257
threadOf: {
244258
populate: {
245-
authorUser: true,
259+
authorUser: {
260+
populate: true,
261+
avatar: { populate: true },
262+
},
246263
},
247264
},
248265
},
@@ -287,7 +304,10 @@ describe('Parser', () => {
287304
},
288305
threadOf: {
289306
populate: {
290-
authorUser: true,
307+
authorUser: {
308+
populate: true,
309+
avatar: { populate: true },
310+
},
291311
},
292312
},
293313
},

server/src/services/__tests__/common.service.test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,12 @@ describe('common.service', () => {
503503
expect(mockCommentRepository.findWithCount).toHaveBeenCalledWith({
504504
pageSize: 10,
505505
page: 1,
506-
populate: { authorUser: { populate: ['avatar'] } },
506+
populate: {
507+
authorUser: {
508+
populate: true,
509+
avatar: { populate: true },
510+
},
511+
},
507512
select: ["id", "content", "related"],
508513
orderBy: { createdAt: "desc" },
509514
where: { authorId: 1 }
@@ -550,7 +555,10 @@ describe('common.service', () => {
550555
select: ['id', 'content', 'related'],
551556
orderBy: { createdAt: 'desc' },
552557
populate: {
553-
authorUser: { populate: ['avatar'] },
558+
authorUser: {
559+
populate: true,
560+
avatar: { populate: true },
561+
},
554562
},
555563
});
556564
});

server/src/services/common.service.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,11 @@ const commonService = ({ strapi }: StrapiContext) => ({
8686
const omit = baseOmit.filter((field) => !REQUIRED_FIELDS.includes(field));
8787
const defaultSelect = (['id', 'related'] as const).filter((field) => !omit.includes(field));
8888

89-
const populateClause = {
90-
authorUser: { populate: ['avatar'] },
89+
const populateClause: clientValidator.FindAllFlatSchema['populate'] = {
90+
authorUser: {
91+
populate: true,
92+
avatar: { populate: true }
93+
},
9194
...(isObject(populate) ? populate : {}),
9295
};
9396
const doNotPopulateAuthor = isAdmin ? [] : await this.getConfig(CONFIG_PARAMS.AUTHOR_BLOCKED_PROPS, []);
@@ -136,7 +139,7 @@ const commonService = ({ strapi }: StrapiContext) => ({
136139

137140
let authorUserPopulate = {};
138141
if (isObject(populate?.authorUser)) {
139-
authorUserPopulate = 'populate' in populateClause.authorUser ? (populateClause.authorUser.populate) : populateClause.authorUser;
142+
authorUserPopulate = 'populate' in populate.authorUser ? (populate.authorUser.populate) : populateClause.authorUser;
140143
}
141144

142145
const primitiveThreadOf = typeof parsedThreadOf === 'number' ? parsedThreadOf : null;

0 commit comments

Comments
 (0)