fix: NPE when accepting war declarations, close #557

WiIIiam278 · WiIIiam278 · commit 753d2635b3bc · 2025-02-02T13:50:40.000Z
diff --git a/common/src/main/java/net/william278/husktowns/war/Declaration.java b/common/src/main/java/net/william278/husktowns/war/Declaration.java
@@ -63,7 +63,7 @@ public static Declaration create(@NotNull Member sender, @NotNull Town defending
     }
 
     public boolean hasExpired() {
-        return OffsetDateTime.now().isAfter(expiryTime);
+        return expiryTime != null && OffsetDateTime.now().isAfter(expiryTime);
     }
 
     @NotNull

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public static Declaration create(@NotNull Member sender, @NotNull Town defending`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`public boolean hasExpired() {`
`66`		`- return OffsetDateTime.now().isAfter(expiryTime);`
	`66`	`+ return expiryTime != null && OffsetDateTime.now().isAfter(expiryTime);`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`@NotNull`