tests (FileReader) Add tests to check configuration file priority

Author: Wtyd

src/ConfigurationFile/FileReader.php

@@ -33,7 +33,7 @@ public function readFile(): array
 
         try {
             $fileExtension = pathinfo($configurationFilePath, PATHINFO_EXTENSION);
-
+            // dd($configurationFilePath);
             if ($fileExtension === 'yml' || $fileExtension === 'yaml') {
                 $configurationFile = Yaml::parseFile($configurationFilePath);
             } elseif ($fileExtension === 'php') {
@@ -69,7 +69,6 @@ public function findConfigurationFile(): string
 
         foreach ($possiblePaths as $path) {
             if (file_exists($path)) {
-                // dd($path);
                 $configFile = $path;
                 break;
             }

tests/Unit/ConfigurationFile/FileReaderTest.php

@@ -130,4 +130,60 @@ function it_throws_exception_when_file_type_is_not_supported()
         $this->expectException(ConfigurationFileNotFoundException::class);
         $this->fileReader->readFile();
     }
+
+    /** @test */
+    function it_prioritizes_php_files_over_yml()
+    {
+        $phpConfig = "<?php return ['tools' => ['phpunit']];";
+        $ymlConfig = $this->configurationFileBuilder->setTools(['phpcs'])->buildYalm();
+
+        $fileSystemStructure = [
+            'githooks.php' => $phpConfig,
+            'githooks.yml' => $ymlConfig
+        ];
+
+        $this->createFileSystem($fileSystemStructure);
+
+        $expectedConfig = ['tools' => ['phpunit']];
+        $fileReaded = $this->fileReader->readFile();
+
+        $this->assertEquals($expectedConfig, $fileReaded);
+    }
+
+    public function configurationFilesInRootAndQaDataProvider()
+    {
+        return [
+            'PHP files' => [
+                "<?php return ['tools' => ['phpunit']];",
+                "<?php return ['tools' => ['phpcs']];",
+                ['tools' => ['phpunit']],
+                'php'
+            ],
+            'YAML files' => [
+                $this->setConfigurationFileBuilder()->setTools(['phpunit'])->buildYalm(),
+                $this->setConfigurationFileBuilder()->setTools(['phpcs'])->buildYalm(),
+                $this->setConfigurationFileBuilder()->setTools(['phpunit'])->buildArray(),
+                'yml'
+            ]
+        ];
+    }
+
+    /**
+     * @test
+     * @dataProvider configurationFilesInRootAndQaDataProvider
+     * When there are valid configuration files in both root and qa directories, it prioritizes files in the root directory
+     */
+    function it_prioritizes_files_in_root_directory_over_files_in_qa_directory($rootFile, $qaFile, $expectedConfig, $fileExtension)
+    {
+        $fileSystemStructure = [
+            "githooks.$fileExtension" => $rootFile,
+            'qa' => ["githooks.$fileExtension" => $qaFile]
+        ];
+
+        $this->createFileSystem($fileSystemStructure);
+
+        $fileReaded = $this->fileReader->readFile();
+
+        $this->assertEquals($expectedConfig, $fileReaded);
+    }
 }