Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Color palette on v0.2.12-Pc91e899a68 build does not match color palette on v0.2.12-5b60745b9f build #767

Closed
1 task done
tsadovska opened this issue Mar 8, 2024 · 5 comments
Labels
bug Something isn't working medium Issue affecting one Tx / User / Chain

Comments

@tsadovska
Copy link

tsadovska commented Mar 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Color palette on v0.2.12-Pc91e899a68 build does not match color palette on v0.2.12-5b60745b9f.

Expected Behavior

Color palette on v0.2.12-Pc91e899a68 build is the same as on v0.2.12-5b60745b9f.

Steps To Reproduce

Compare Assets list:

  1. Select Ethereum network
  2. Connect MetaMask wallet
  3. Compare Assets list

Compare Colors in Route section:

  1. Prepare to send 0.001 ETH from Ethereum (MetaMask) to Fantom (MetaMask)
  2. Compare colors in Route section

Environment

- OS: macOS 14.2.1 (23C71)
- Wallet: MetaMask 
- Browser: Version 122.0.6261.112 (Official Build) (arm64)

Anything else?

image

image

Screenshot 2024-03-08 at 09 39 47

@tsadovska tsadovska added bug Something isn't working medium Issue affecting one Tx / User / Chain labels Mar 8, 2024
@tsadovska tsadovska changed the title [bug] Color palette on v0.2.12-Pc91e899a68 build does not match color palette on v0.2.12-5b60745b9f [bug] Color palette on v0.2.12-Pc91e899a68 build does not match color palette on v0.2.12-5b60745b9f build Mar 8, 2024
@AigaD
Copy link

AigaD commented Mar 11, 2024

Tested from: https://preview.portalbridge.com/#
Add to your wallet design is shown differently for some assets. For some the icon has the correct Asset icon colour, but for some all the text and icon are shown in blue font.

Attachment:
Screenshot 2024-03-11 at 12 07 28

Screenshot 2024-03-11 at 11 50 04

@artursapek
Copy link
Contributor

yeah I probably caused this in wormhole-foundation/wormhole-connect#1698

@artursapek
Copy link
Contributor

@AigaD
Copy link

AigaD commented Mar 12, 2024

Tested from: https://portalbridge.com/ and https://preview.portalbridge.com/b05f4e9322/#
Colour contrast for warning messages "Wallet disconnected, please connect a supported wallet" and "Select an asset" are different
Attachment:

Screenshot 2024-03-12 at 13 46 43

Screenshot 2024-03-12 at 13 43 58

@tsadovska
Copy link
Author

Tested OK.

  • Correct colors are used on "Select asset" screen
  • Correct colors are used in Route section
  • Correct colors are used in "Add to your wallet" link
  • Correct color is used for loading icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium Issue affecting one Tx / User / Chain
Projects
None yet
Development

No branches or pull requests

3 participants